Last modified: 2013-11-30 05:51:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59609, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57609 - MassMessage's #target parser function suddenly broken on Meta-Wiki
MassMessage's #target parser function suddenly broken on Meta-Wiki
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
MassMessage (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-26 18:46 UTC by MZMcBride
Modified: 2013-11-30 05:51 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2013-11-26 18:46:03 UTC
"{{#target:User talk:Jimbo Wales}}" previously output a link to [[m:User talk:Jimbo Wales]] on Meta-Wiki. Very recently it began outputting nothing at all. Something is broken.
Comment 1 MZMcBride 2013-11-26 18:50:26 UTC
This appears to be specific to Meta-Wiki. Compare:

* https://meta.wikimedia.org/w/index.php?oldid=6521064

* https://en.wikipedia.org/w/index.php?oldid=583419676

Both contain the same content: "{{#target:User talk:Jimbo Wales}}".

On the English Wikipedia, correct output:

---
<p><a href="/wiki/User_talk:Jimbo_Wales" title="User talk:Jimbo Wales">User talk:Jimbo Wales</a></p>
---

On Meta-Wiki, broken output:

---
<div id="mw-content-text" lang="en" dir="ltr" class="mw-content-ltr">

<!-- 
NewPP limit report
Parsed by mw1049
CPU time usage: 0.008 seconds
Real time usage: 0.009 seconds
Preprocessor visited node count: 3/1000000
Preprocessor generated node count: 14/1500000
Post‐expand include size: 0/2048000 bytes
Template argument size: 0/2048000 bytes
Highest expansion depth: 2/40
Expensive parser function count: 0/500
-->

<!-- Saved in parser cache with key metawiki:pcache:idhash:141962-0!*!*!*!*!*!* and timestamp 20131126184712
 -->
</div>
---
Comment 3 MZMcBride 2013-11-26 18:53:42 UTC
Continuing to poke at this with Bartosz's help... both metawiki and enwiki are running "1.23wmf4 (49ec115)" according to Special:Version.

The MySQL versions are different, but I can't imagine that would be the issue here.

Nothing in [[wikitech:SAL]] looks suspicious off-hand, though this is a very recent breakage.
Comment 4 MZMcBride 2013-11-26 18:55:01 UTC
(In reply to comment #2)
> https://meta.wikimedia.org/w/index.php?diff=6476799&oldid=6466601

Err, okay, so this is documented, yet still completely unexpected. What's going on here?
Comment 5 Kunal Mehta (Legoktm) 2013-11-26 18:57:50 UTC
The 'massmessage-target' message was blanked (https://meta.wikimedia.org/w/index.php?title=MediaWiki:Massmessage-target&action=history), so that the output of the message can be controlled via the normal {{target}} template, which doesn't require editinterface to modify. There is probably a better way to do this though.

The parserfunction still works, it just doesn't display any output.
Comment 6 MZMcBride 2013-11-26 19:00:32 UTC
(In reply to comment #5)
> The parserfunction still works, it just doesn't display any output.

Grahhh. Thank you for explaining.

Overall, blanking [[m:MediaWiki:Massmessage-target]] is a terrible hack. One of its symptoms is that it results in #target failing silently. This needs further thought and a proper fix.
Comment 7 Kunal Mehta (Legoktm) 2013-11-30 05:51:01 UTC
Ok, so now [[m:Template:target]] wraps around the #target parser function which displays [[m:Template:target/display]]. Using either the template or the parser function will work.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links