Last modified: 2013-12-02 23:25:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59654, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 57654 - VisualEditor: Save dialog not torn down properly after edit
VisualEditor: Save dialog not torn down properly after edit
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2013-12-05
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-11-27 13:34 UTC by Ed Sanders
Modified: 2013-12-02 23:25 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ed Sanders 2013-11-27 13:34:52 UTC 
Consequently the second time you edit a page, it thinks the save dialog already exists so it isn't set up again, and it fails to render.

We should add a "double edit" workflow to our Selenium or manual tests.
Comment 1 Ed Sanders 2013-11-27 13:46:25 UTC 
Specifically when the surface is torn down the surface overlays are detached.
Comment 2 Gerrit Notification Bot 2013-11-27 14:03:46 UTC 
Change 97913 had a related patch set uploaded by Esanders:
Tear down the save dialog and remove it from memory on surface teardown

https://gerrit.wikimedia.org/r/97913
Comment 3 Gerrit Notification Bot 2013-12-01 22:23:08 UTC 
Change 97913 merged by jenkins-bot:
Tear down the save dialog and remove it from memory on surface teardown

https://gerrit.wikimedia.org/r/97913
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links