Last modified: 2013-11-28 10:23:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59672, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57672 - Special:AggregateGroups is not compatible with MW 1.20 and 1.21
Special:AggregateGroups is not compatible with MW 1.20 and 1.21
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Translate (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-27 17:58 UTC by Niklas Laxström
Modified: 2013-11-28 10:23 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Niklas Laxström 2013-11-27 17:58:14 UTC
Unknown dependency jquery.chosen. Was included in 1.22.x releases onwards. Suggested fix is to bundle our own copy and register it if the module is not present already.

Reported at: https://www.mediawiki.org/wiki/Thread:Extension_talk:Translate/Special:Aggregate_groups_page_not_working/reply
Comment 1 Siebrand Mazeland 2013-11-27 20:53:12 UTC
Nice catch. This blocks MLEB 2013.11's compatibility with 1.20 and 1.21.
Comment 2 Rainer Rillke @commons.wikimedia 2013-11-27 21:26:10 UTC
Sorry, I didn't notice that the translate extension should work with MW 1.21, otherwise I wouldn't have included that. https://www.mediawiki.org/wiki/MediaWiki_Language_Extension_Bundle didn't give any other help about that requirement, should have had a look at https://www.mediawiki.org/wiki/Extension:Translate ...
Comment 3 Rainer Rillke @commons.wikimedia 2013-11-27 21:30:25 UTC
If I should revert my change out, please let me know.
Comment 4 Siebrand Mazeland 2013-11-27 21:38:49 UTC
(In reply to comment #3)
> If I should revert my change out, please let me know.

No need. We will see if we can implement a solution tomorrow, or exclude the change from the MLEB release until we do have the time to update master.
Comment 5 Kartik Mistry 2013-11-28 03:57:00 UTC
We have started adding MediaWiki compatibility in Release Notes[1] recently. I'll update MLEB page[2] too.

[1] http://lists.wikimedia.org/pipermail/mediawiki-i18n/2013-October/000762.html
[2] https://www.mediawiki.org/wiki/MediaWiki_Language_Extension_Bundle
Comment 6 Gerrit Notification Bot 2013-11-28 07:22:57 UTC
Change 98072 had a related patch set uploaded by Siebrand:
Revert "Make Special:AggregateGroups using jquery.chosen"

https://gerrit.wikimedia.org/r/98072
Comment 7 Gerrit Notification Bot 2013-11-28 09:02:59 UTC
Change 98075 had a related patch set uploaded by Nikerabbit:
Bundle jquery.chosen and load if for older MediaWiki

https://gerrit.wikimedia.org/r/98075
Comment 8 Gerrit Notification Bot 2013-11-28 09:31:09 UTC
Change 98075 merged by jenkins-bot:
Bundle jquery.chosen and load it for older MediaWiki

https://gerrit.wikimedia.org/r/98075
Comment 9 Gerrit Notification Bot 2013-11-28 10:05:30 UTC
Change 98072 abandoned by Siebrand:
Temporarily revert "Make Special:AggregateGroups using jquery.chosen"

Reason:
Niklas decided to get mad about reduction of features, and just implemented BC in https://gerrit.wikimedia.org/r/#/c/98075/. Yay.

https://gerrit.wikimedia.org/r/98072
Comment 10 Siebrand Mazeland 2013-11-28 10:23:42 UTC
(In reply to comment #9)
> Reason:
> Niklas decided to get mad about reduction of features, and just implemented
> BC in https://gerrit.wikimedia.org/r/#/c/98075/. Yay.

Just to make sure this is not being misinterpreted: It was meant as a joke.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links