Last modified: 2014-02-07 22:31:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59678, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 57678 - Use This File dialog is probably broken now
Use This File dialog is probably broken now
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
MultimediaViewer (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
gci2013
: easy
Depends on:
Blocks: 56787
  Show dependency tree / graph
 
Reported: 2013-11-27 20:06 UTC by Mark Holmquist
Modified: 2014-02-07 22:31 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Mark Holmquist 2013-11-27 20:06:11 UTC 
The refactor of the UI initialisation may have broken this because it changed the value of "this" for the dialog opener function. Should be pretty quick to fix, just use this.$useFile instead of screwing around with $this and $( this ).

Marking as a candidate for GCI, but vandrew might fix it before we can write it up.
Comment 1 Gerrit Notification Bot 2013-11-27 23:02:40 UTC 
Change 98020 had a related patch set uploaded by MarkTraceur:
Replaced this.$useFile instead of  with $this inf ext.multimediaViewer.lightboxinterface.js

https://gerrit.wikimedia.org/r/98020
Comment 2 Gerrit Notification Bot 2013-11-28 21:30:29 UTC 
Change 98020 merged by jenkins-bot:
Fixes the UI refactor

https://gerrit.wikimedia.org/r/98020
Comment 3 Quim Gil 2014-02-07 22:26:50 UTC 
The patch is merged. Is there anything still missing in order to consider this bug fixed?
Comment 4 Tisza Gergő 2014-02-07 22:31:32 UTC 
Use This File is working on mw.org right now.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links