Last modified: 2014-11-17 21:36:25 UTC
When I use git-review with one of the repositories installed by vagrant, I end up with two remotes, 'origin' and 'gerrit'. When I follow the instructions on the MediaWiki page and set things up manually, there is only 'origin', and git-review behaves a lot better. The difference is probably caused by [gerrit] defaultremote = origin in ~/.config/git-review/git-review.conf - this should be added by default.
I don't think that MediaWiki-Vagrant should be attempting to modify anything in $HOME on the host machine. Are you wanting a git-review.conf created for the vagrant user account in the guest VM? This may all be made moot if Yuri finds a solution for bug 46870.
For the guest VM, yes. I'm not sure bug 46870 affects this; for one thing, not every extension has a vagrant role. Also, I would expect vagrant to respect my defaultremote setting when cloning extensions (which it would if you simply run git-review -s instead of creating remotes by hand, which seems a whole lot safer anyway.) Alternatively, you might try to look for a defaultremote setting on the host machine and copy that if it exists.
(In reply to Tisza Gergő from comment #0) > this should be added by default. Yeah, I agree. It makes git-review saner.
Change 146014 had a related patch set uploaded by Ori.livneh: git-review: configure 'origin' as the default remote https://gerrit.wikimedia.org/r/146014
Bulk unassigning bugs from Ori.
