Last modified: 2013-12-05 16:52:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59687, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 57687 - Additional SQL query cleanup is needed
Additional SQL query cleanup is needed
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Wikimania Scholarships (Other open bugs)
wmf-deployment
All All
: High normal (vote)
: ---
Assigned To: Bryan Davis
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-11-27 22:58 UTC by Bryan Davis
Modified: 2013-12-05 16:52 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bryan Davis 2013-11-27 22:58:35 UTC 
* A few string concatenations remain in the query builder
* There is a lot of cut-n-paste subquery code
* There are unused functions in Dao\Apply

In general look for and try to fix things in the DAO that will fail the security review or make it harder for the reviewer.
Comment 1 Gerrit Notification Bot 2013-11-27 23:11:37 UTC 
Change 98024 had a related patch set uploaded by BryanDavis:
Cleanup DAO layer

https://gerrit.wikimedia.org/r/98024
Comment 2 Gerrit Notification Bot 2013-12-03 18:50:31 UTC 
Change 98024 merged by jenkins-bot:
Cleanup DAO layer

https://gerrit.wikimedia.org/r/98024
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links