Last modified: 2013-12-13 20:21:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59694, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57694 - Review mediawiki.ApiRequest.js to ensure that DoesNotExistError logging is useful and informative in all cases.
Review mediawiki.ApiRequest.js to ensure that DoesNotExistError logging is us...
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
Web API (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-28 00:33 UTC by spage
Modified: 2013-12-13 20:21 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2013-11-28 00:33:00 UTC
We are trying to debug a failure with the way parsoid is set up in the Labs-Vagrant visualeditor role setup
<https://wikitech.wikimedia.org/wiki/Talk:Labs-vagrant#Parsoid_errors_using_VisualEditor_role>

When the client gets 404 errors, the error in /var/log/upstart/parsoid.log is just 
  ERROR in localhost:Main_Page
  Stack trace: DoesNotExistError: Page Fetch failure for null
  worker 25269 died (1), restarting.

but it doesn't say what the error is.
ebernhardson tweaked the second line to actually say what's going wrong by adding error to the output, so the second line becomes

  Stack trace: DoesNotExistError: Page Fetch failure for null : Error: Invalid URI "undef/w/api.php?format=json&action=query&meta=siteinfo&siprop=namespaces%7Cnamespacealiases%7Cmagicwords%7Cfunctionhooks%7Cextensiontags%7Cgeneral%7Cinterwikimap%7Clanguages%7Cprotocols"

, and now we can get somewhere :)

Two-line patch on its way
Comment 1 Gerrit Notification Bot 2013-11-28 00:46:54 UTC
Change 98038 had a related patch set uploaded by Spage:
More informative DoesNotExistError logging.

https://gerrit.wikimedia.org/r/98038
Comment 2 ssastry 2013-12-04 15:43:18 UTC
Let us leave this bug open even after this patch is merged. We should review all our response handlers and make sure we are emitting informative log messages based on the error that is returned. Looking at the code, I see that we return early in many handlers.
Comment 3 Gerrit Notification Bot 2013-12-04 18:53:55 UTC
Change 98038 merged by jenkins-bot:
More informative DoesNotExistError logging.

https://gerrit.wikimedia.org/r/98038
Comment 4 ssastry 2013-12-05 19:19:27 UTC
I changed the title so we can review that we do have useful logging in all handlers and wanted to keep this open till we have actually reviewed it.
Comment 5 Gerrit Notification Bot 2013-12-13 19:55:49 UTC
Change 101336 had a related patch set uploaded by GWicke:
More informative DoesNotExistError logging.

https://gerrit.wikimedia.org/r/101336
Comment 6 Gerrit Notification Bot 2013-12-13 19:56:51 UTC
Change 101336 merged by GWicke:
More informative DoesNotExistError logging.

https://gerrit.wikimedia.org/r/101336

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links