Last modified: 2013-11-28 03:34:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59701, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 57701 - puppet config of Parsoid localsettings breaks in labs-vagrant


Summary:	puppet config of Parsoid localsettings breaks in labs-vagrant

Status:	RESOLVED FIXED

Product:	MediaWiki-Vagrant
Classification:	Unclassified
Component:	General (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal
Target Milestone:	---
Assigned To:	Ori Livneh

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-11-28 02:44 UTC by spage
Modified:	2013-11-28 03:34 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description spage 2013-11-28 02:44:20 UTC

Parsoid doesn't work when you add the visualeditor role in Labs-Vagrant setup,
clients get 404 errors. After tweaking parsoid to log the actual error (bug 57694), /var/log/upstart/parsoid.log contains

  Stack trace: DoesNotExistError: Page Fetch failure for null : Error: Invalid URI
  "undef/w/api.php?format=json&action=query&meta=siteinfo&siprop=namespaces%7Cnamespacealiases%7Cmagicwords%7Cfunctionhooks%7Cextensiontags%7Cgeneral%7Cinterwikimap%7Clanguages%7Cprotocols"

Obviously undef/w/api.php is going to give 404.

The bad URL path arises because puppet/manifests/roles.pp sets $server_url to 'undef' if forwarded_port isn't set, and it somehow isn't set in labs-vagrant. puppet/modules/mediawiki/templates/parsoid.localsettings.js.erb propagates this to /srv/parsoid/js/api/localsettings.js which contains 
  parsoidConfig.setInterwiki( 'localhost', 'undef/w/api.php' )

(Erik Bernhardson figured all this out!)

One fix is to not set $server_url to undef. Patch coming.

Comment 1 Gerrit Notification Bot 2013-11-28 03:23:13 UTC

Change 98060 had a related patch set uploaded by Spage:
Set $server_url to something other than undef

https://gerrit.wikimedia.org/r/98060

Comment 2 Gerrit Notification Bot 2013-11-28 03:33:54 UTC

Change 98060 merged by Ori.livneh:
Set $server_url to something other than undef

https://gerrit.wikimedia.org/r/98060

Comment 3 Ori Livneh 2013-11-28 03:34:26 UTC

Thanks for the detailed report and the patch.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links