Last modified: 2014-10-19 17:44:13 UTC
extensions/Flow/tests/browser/edit_existing.feature times out in some browsers, e.g. <https://wmf.ci.cloudbees.com/view/r-fl/job/Flow-en.wikipedia.beta.wmflabs.org-linux-firefox/83/testReport/%28root%29/Edit%20existing%20title/Edit_existing_post/> prints timed out after 5 seconds, waiting for {:title=>"Edit post", :tag_name=>"a"} to become present (Watir::Wait::TimeoutError) ./features/step_definitions/edit_existing_steps.rb:4:in `block (2 levels) in <top (required)>' ./features/step_definitions/edit_existing_steps.rb:2:in `/^I click the Edit post pencil icon$/' features/edit_existing.feature:17:in `When I click the Edit post pencil icon' I think this might be because the post it's trying to edit is not fully in view. Looking at the failed browser test the post it's trying to edit is barely visible. I found if I run the test myself it passes, but if I resize the WebDriver window less tall during the test then I can trigger this failure. It may also be related to the animated fade-in on hover of the pencil icon. As a temporary workaround I replaced the header text in http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:Flow_QA with an HTML comment so it's more likely the post will be visible, but I think the test would be more robust if it somehow scrolled the post into view. Disclaimer I have no idea how WebDriver and the page object work :)
Change 98732 had a related patch set uploaded by Cmcmahon: experimental fix for Bug 57702 https://gerrit.wikimedia.org/r/98732
Change 98732 abandoned by Cmcmahon: experimental fix for Bug 57702 Reason: redundant https://gerrit.wikimedia.org/r/98732
