Last modified: 2014-09-24 10:18:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59709, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57709 - Wikidata: CTRL+click and middle click on search suggestions doesn't open the page in a new tab
Wikidata: CTRL+click and middle click on search suggestions doesn't open the ...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=frontend p=3 s=2014-07-01
: need-volunteer
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-28 12:32 UTC by Helder
Modified: 2014-09-24 10:18 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Helder 2013-11-28 12:32:27 UTC
The feature should work as in any Wikipedia.
Comment 1 Helder 2014-03-07 14:49:52 UTC
Ping!
Comment 2 Andre Klapper 2014-03-07 14:53:54 UTC
Helder: Ping what? Do you have question?
Comment 3 Helder 2014-03-07 15:19:55 UTC
This is just very very annoying and was fixed very quickily in every other extension where this kind of problem happened with some of the clickable interface.
Comment 4 Helder 2014-07-03 12:55:28 UTC
How can this be any more difficult than fixing bug 43373 [1] or even bug 56905 [2]?

This feature already works by default in the search suggestion field of other WMF wikis since Change-Id: I87940ca86a2b3776969cbcee8cdf93e3c66b0cd9.

It only fails on Wikidata.

[1] https://gerrit.wikimedia.org/r/#/c/42541/3/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.track.js,unified
[2] https://gerrit.wikimedia.org/r/#/c/94971/1/js/ext.multimediaViewer.js,unified
Comment 5 Bartosz Dziewoński 2014-07-03 12:58:29 UTC
Wikidata apparently reimplements the feature from scratch, so the fix would also have to be reimplemented from scratch.
Comment 6 Thiemo Mättig 2014-07-03 15:26:44 UTC
https://gerrit.wikimedia.org/r/#/c/142510/
Comment 7 Lydia Pintscher 2014-07-03 15:27:56 UTC
(In reply to Bartosz Dziewoński from comment #5)
> Wikidata apparently reimplements the feature from scratch, so the fix would
> also have to be reimplemented from scratch.

Yeah. We've recently re-written this part. Now it is easier to fix. It is still not an "easy" bug :)

We have a patch now as Thiemo linked above.
Comment 8 Helder 2014-07-19 19:44:16 UTC
Still not working when I go to
https://www.wikidata.org
and type "WP:Test" in the search box and then in the "Containing... WP:Test" suggestion.
Comment 9 Thiemo Mättig 2014-07-21 08:59:24 UTC
(In reply to Helder from comment #8)
> Still not working [...] in the "Containing [...]

That's consistent to MediaWiki's core suggester. Sure, that's no reason to not have this feature. But if we do this we should fix core's suggester too to be consistent again.
Comment 10 Helder 2014-07-22 01:41:48 UTC
It works fine on core[1] and just fails on Wikidata. But yes, the behavior should be consistent.

[1] I just tested it using Firefox 30.0 on
https://en.wikipedia.org/wiki/Special:Watchlist
by typing "test" and CTRL+clicking the suggestion I got
https://en.wikipedia.org/w/index.php?search=test&title=Special%3ASearch&fulltext=1
in a new tab. On wikidata the page was reloaded instead.
Comment 11 Lydia Pintscher 2014-09-24 10:18:12 UTC
Marking this as fixed. We have bug 66432 for the remaining issue.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links