Last modified: 2014-11-20 13:32:50 UTC
1) Enable "Edit pages on double click" at https://www.wikidata.org/wiki/Special:Preferences?uselang=en#mw-prefsection-editing 2) Go to https://www.wikidata.org/wiki/Q5299984?debug=1 3) Double click The line $( '#ca-edit a' ).get( 0 ).click(); from https://bits.wikimedia.org/static-1.23wmf4/resources/mediawiki.action/mediawiki.action.view.dblClickEdit.js will cause Uncaught TypeError: Cannot call method 'click' of undefined
This is still reproducible (tested with Firefox 33). The code is now at https://bits.wikimedia.org/static-1.25wmf8/resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js
Isn't this a core error then? Can you please move it?
Maybe. But all non-Wikidata pages have a "ca-edit" link, so the code works fine.
Change 174679 had a related patch set uploaded by Thiemo Mättig (WMDE): Do not call click on undefined https://gerrit.wikimedia.org/r/174679
(In reply to Helder from comment #3) > all non-Wikidata pages have a "ca-edit" link The code is in core. Core shouldn't make such assumptions, especially since ContentHandlers are supported. However, creating a fix is dead simple. Merging not so much. Let's see what happens.
Just to clarify: the feature should work (not just not trow an error). When the user double click in a field, it should enter in edit mode.
(In reply to Helder from comment #6) > When > the user double click in a field, it should enter in edit mode. That's unrelated to this report. Please open a separate one for this feature request.
