Last modified: 2013-12-13 22:22:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59778, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 57778 - VisualEditor: newFromDocumentInsertion not implemented properly for reference/media insertions
VisualEditor: newFromDocumentInsertion not implemented properly for reference...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2013-12-05
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-11-30 18:30 UTC by Ed Sanders
Modified: 2013-12-13 22:22 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ed Sanders 2013-11-30 18:30:39 UTC 
Currently inserting a new reference fails because of changes to newFromDocumentInsertion. The first thing that looks wrong is that the 'empty' document we generate for new references/media captions contains one paragraph and an empty internal list, I suspect we need to copy the existing internal list over.

Even with that fixed it appears we aren't generating the correct sequence of transactions so they need to be reviewed.
Comment 1 Ed Sanders 2013-12-13 10:48:59 UTC 
Fixed a while ago.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links