Last modified: 2013-12-03 14:23:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59825, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 57825 - SyntaxHighlight GeSHi should use mw-code class
SyntaxHighlight GeSHi should use mw-code class
Status: REOPENED
Product: MediaWiki extensions
Classification: Unclassified
SyntaxHighlight (GeSHi) (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-12-02 03:43 UTC by Minh Nguyễn
Modified: 2013-12-03 14:23 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Minh Nguyễn 2013-12-02 03:43:35 UTC 
The contents of a page in the Module: namespace are wrapped in a <pre> tag with the classes `lua source-lua`. That <pre> tag should also have the class `mw-code` so it can take advantage of any CSS rules applied to system-generated <pre> tags, such as the one I've proposed in bug 57824.
Comment 1 Brad Jorsch 2013-12-02 15:56:57 UTC 
Scribunto does use mw-code when generating <pre> tags itself.

When using SyntaxHighlight_GeSHi, the <pre> is generated by that extension and Scribunto has no control over it.
Comment 2 Minh Nguyễn 2013-12-03 08:56:10 UTC 
Makes sense. But there is still a bug to be fixed, only it's in SyntaxHighlight GeSHi rather than Scribunto.
Comment 3 Brad Jorsch 2013-12-03 14:23:07 UTC 
Why not for .js and .css pages too? No reason at all to limit this to just Scribunto modules.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links