Last modified: 2013-12-04 05:20:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59826, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57826 - SyntaxHighlight should not convert tabs to 8 spaces
SyntaxHighlight should not convert tabs to 8 spaces
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SyntaxHighlight (GeSHi) (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
https://www.mediawiki.org/wiki/User:M...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-02 03:54 UTC by Minh Nguyễn
Modified: 2013-12-04 05:20 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Minh Nguyễn 2013-12-02 03:54:12 UTC
Now that bug 39616 is fixed, the SyntaxHighlight extension is converting every tab to a series of eight spaces. This transformation prevents the fix for bug 57824 from having any effect on <source> tags. It's also inconsistent with the CodeEditor extension, which displays tabs as four spaces and binds the Tab key to the tab character (bug 39616). While an eight-character wide tab may make sense in some contexts, replacing a tab with eight spaces would seem contrary to user intent in the vast majority of cases.

Possibly a regression of bug 30930?
Comment 1 Minh Nguyễn 2013-12-02 04:04:57 UTC
Naturally, this bug breaks GeSHi's support for the Whitespace language, as seen in the URL above.
Comment 2 Brad Jorsch 2013-12-02 15:59:02 UTC
(In reply to comment #0)
> Possibly a regression of bug 30930?

No, it's not. Bug 30930 was that Tidy's tabs-to-spaces change was making code be unaligned, and that was fixed by converting tabs-to-spaces before highlighting the code.
Comment 3 Gerrit Notification Bot 2013-12-02 16:42:05 UTC
Change 98540 had a related patch set uploaded by Anomie:
Protect tabs from HTML Tidy

https://gerrit.wikimedia.org/r/98540
Comment 4 Gerrit Notification Bot 2013-12-02 19:18:01 UTC
Change 98540 merged by jenkins-bot:
Protect tabs from HTML Tidy

https://gerrit.wikimedia.org/r/98540
Comment 5 Brad Jorsch 2013-12-02 19:27:36 UTC
Patch is merged, and should be deployed to WMF wikis with 1.23wmf6. See https://www.mediawiki.org/wiki/MediaWiki_1.23/Roadmap for the schedule.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links