Last modified: 2013-12-31 20:55:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59874, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57874 - Special:Contributions RSS has 1 more than limit
Special:Contributions RSS has 1 more than limit
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
1.23.0
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-02 19:41 UTC by Bawolff (Brian Wolff)
Modified: 2013-12-31 20:55 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bawolff (Brian Wolff) 2013-12-02 19:41:45 UTC
Consider: https://www.mediawiki.org/w/api.php?action=feedcontributions&user=Bawolff&feedformat=atom&limit=2 (note the limit=2)

Expected behaviour: 2 items

Actual behaviour: 3 items.

(Probably should check if related things also have this off by one error)
Comment 1 Umherirrender 2013-12-07 19:35:37 UTC
Api also gives a feedwatchlist action, which need also check.

The Pager class usually select one more than the limit to support the next links.
But the api is using the whole result and does not count himself, if the limit is reached. By the way: limit parameter is not legal supported by the api action feedcontributions (not documented on api.php).
Comment 2 Gerrit Notification Bot 2013-12-30 19:52:22 UTC
Change 104551 had a related patch set uploaded by Umherirrender:
Special:Contributions RSS has 1 more than limit

https://gerrit.wikimedia.org/r/104551
Comment 3 Umherirrender 2013-12-30 19:58:07 UTC
(In reply to comment #1)
> Api also gives a feedwatchlist action, which need also check.

feedwatchlist does not have this problem, because it does not support custom limits (Special:Watchlist does not support limits too).
Comment 4 Gerrit Notification Bot 2013-12-31 20:45:33 UTC
Change 104551 merged by jenkins-bot:
action=feedcontributions no longer has one item more than limit

https://gerrit.wikimedia.org/r/104551
Comment 5 Brad Jorsch 2013-12-31 20:55:43 UTC
Merged. Should be deployed to WMF wikis with 1.23wmf9, see https://www.mediawiki.org/wiki/MediaWiki_1.23/Roadmap for the schedule.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links