Last modified: 2013-12-17 15:36:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59880, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 57880 - git-deploy doesn't sync submodules
git-deploy doesn't sync submodules
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Deployment systems (Other open bugs)
wmf-deployment
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-12-02 20:15 UTC by Antoine "hashar" Musso (WMF)
Modified: 2013-12-17 15:36 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2013-12-02 20:15:19 UTC 
The integration/jenkins.git project is available for deployment on tin.eqiad.wmnet under /srv/deployment/integration/slave-scripts

That repositories has some submodules, to deploy it I went with:

 git deploy start
 git submodule update --init
 git deploy sync

All the target have received a copy of the main git repository but the submodules ARE NOT THERE.

Expected behavior: `git deploy sync` should replicate the repository on the deployment machine in the exact same state.
Comment 1 Gerrit Notification Bot 2013-12-03 09:35:25 UTC 
Change 98778 had a related patch set uploaded by Hashar:
deployment: integration/slave-scripts has submodules

https://gerrit.wikimedia.org/r/98778
Comment 2 Gerrit Notification Bot 2013-12-03 10:08:27 UTC 
Change 98778 merged by Ryan Lane:
deployment: integration/slave-scripts has submodules

https://gerrit.wikimedia.org/r/98778
Comment 3 Andre Klapper 2013-12-17 09:36:49 UTC 
hashar: Does this require more work (if so what) or has merging the patch in comment 2 fixed this?
Comment 4 Antoine "hashar" Musso (WMF) 2013-12-17 15:36:09 UTC 
I think Ryan hint to add:

 'checkout_submodules'   => true,

Fix the issue. I was assuming git deploy would handle submodules by default.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links