Last modified: 2014-01-27 18:31:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59899, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 57899 - Jenkins: Install node-csslint


Summary:	Jenkins: Install node-csslint

Status:	RESOLVED FIXED

Product:	Wikimedia
Classification:	Unclassified
Component:	Continuous integration (Other open bugs)
Version:	wmf-deployment
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-12-02 23:35 UTC by Krinkle
Modified:	2014-01-27 18:31 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Krinkle 2013-12-02 23:35:02 UTC

Also, set up initial jobs for projects that already use csslint in their local-dev Gruntfile (oojs-ui and visualeditor at the moment).

Comment 1 Gerrit Notification Bot 2013-12-02 23:35:15 UTC

Change 98722 had a related patch set uploaded by Krinkle:
Install Grunt plugin for csslint

https://gerrit.wikimedia.org/r/98722

Comment 2 Gerrit Notification Bot 2013-12-02 23:50:42 UTC

Change 98722 merged by jenkins-bot:
Install Grunt plugin for csslint

https://gerrit.wikimedia.org/r/98722

Comment 3 Gerrit Notification Bot 2013-12-03 19:13:23 UTC

Change 98868 had a related patch set uploaded by Krinkle:
Create macro for csslint and use in oojs-ui and VisualEditor

https://gerrit.wikimedia.org/r/98868

Comment 4 Gerrit Notification Bot 2013-12-03 19:30:08 UTC

Change 98868 merged by Krinkle:
Create macro for csslint and use in oojs-ui and VisualEditor

https://gerrit.wikimedia.org/r/98868

Comment 5 Umherirrender 2013-12-06 19:56:27 UTC

Does that also lint less or is there a extra tool?

Comment 6 Krinkle 2014-01-27 18:30:27 UTC

This has been installed, deployed and is now also actively used by various projects.

In the main 'test' pipelines, however, this is no longer used as we have since migrated to using npm-test (from package.json) directly by installing it in a virtual machine in labs and executing it as specified by the source repository (instead of the install provided by Jenkins).

Comment 7 Krinkle 2014-01-27 18:31:13 UTC

(In reply to comment #5)
> Does that also lint less or is there a extra tool?

No, we don't yet use cssslint in mediawiki-core (current code doesn't pass) and neither does it validate LESS in any way.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links