Last modified: 2013-12-05 19:46:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59904, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57904 - Flow: empty [[user:]] string causes PHP Catchable fatal error
Flow: empty [[user:]] string causes PHP Catchable fatal error
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-03 00:46 UTC by Quiddity
Modified: 2013-12-05 19:46 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Quiddity 2013-12-03 00:46:13 UTC
A post with the string "[[user:]]" or "[[user:|]]" causes the page it is on to display without CSS. (See attachment 13963 [details] for screenshot)

I fixed the two examples that we know of, and if I try to create a new post with that string, Flow tells me "An error occurred while contacting the server."

One of the examples was in this post: http://ee-flow.wmflabs.org/w/index.php?title=Sandbox&workflow=0509a4fb42af34dffb6efa163e68c4ac&action=view#flow-post-0509a564875f34dffb6efa163e68c4ac
the other was in 
http://ee-flow.wmflabs.org/w/index.php?title=Talk:Flow_Team_Retrospective&workflow=0508e5028e9f34dffb6efa163e68c4ac&action=view#flow-post-0508e50acd0734dffb6efa163e68c4ac


Spage pulled this out of the logs: 

[Tue Dec 03 00:16:58 2013] [error] [client 76.14.75.43] PHP Catchable fatal error:  Argument 1 passed to DOMDocument::importNode() must be an instance of DOMNode, null given, called in /srv/mediawiki/extensions/Flow/includes/Templating.php on line 356 and defined in /srv/mediawiki/extensions/Flow/includes/Templating.php on line 425

Not a parsoid problem (confirmed by spage thru testing)
Comment 1 Bingle 2013-12-03 00:54:28 UTC
The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/565, but people from the community are welcome to contribute here and in Gerrit.
Comment 2 Gerrit Notification Bot 2013-12-03 01:12:13 UTC
Change 98744 had a related patch set uploaded by EBernhardson:
Gracefully handle invalid links when handling redlinks

https://gerrit.wikimedia.org/r/98744
Comment 3 Gerrit Notification Bot 2013-12-03 11:20:42 UTC
Change 98744 merged by jenkins-bot:
Gracefully handle invalid links when handling redlinks

https://gerrit.wikimedia.org/r/98744

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links