Last modified: 2013-12-13 01:58:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59926, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57926 - beta: Parsoid is returning the wrong articles
beta: Parsoid is returning the wrong articles
Status: RESOLVED FIXED
Product: Wikimedia Labs
Classification: Unclassified
deployment-prep (beta) (Other open bugs)
unspecified
All All
: Highest major
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-03 14:52 UTC by Željko Filipin
Modified: 2013-12-13 01:58 UTC (History)
12 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Željko Filipin 2013-12-03 14:52:56 UTC
- go to any article
- edit it with visual editor
- instead of text of the article in visual editor, text of another article appears

- reproducible for every article I have tried at http://en.wikipedia.beta.wmflabs.org/
- not reproducible at http://test2.wikipedia.org/
Comment 1 James Forrester 2013-12-03 16:02:50 UTC
This very much looks like an artefact of the changes for bug 57233 - marking as such.
Comment 2 Antoine "hashar" Musso (WMF) 2013-12-03 16:15:21 UTC
I have updated Parsoid code on deployment-parsoid2 in /srv/deployment/parsoid/Parsoid

Forgot to run npm install to update the node modules, might be related :/
Comment 3 Chris McMahon 2013-12-03 16:34:49 UTC
The articles returned do not seem to originate from beta enwiki or production enwiki
Comment 4 Antoine "hashar" Musso (WMF) 2013-12-03 17:04:51 UTC
I upgraded the varnish on parsoidcache instance while I was investigating.

Now it seems VE is querying the parsoid with some invalid URL and it popup a 404 error :-/   Nothing obvious in the logs though, maybe VE has a wgDebugLogGroup we should enable to get more logs.
Comment 5 Antoine "hashar" Musso (WMF) 2013-12-03 20:16:45 UTC
There is no more 404 errors but some articles still gives content that does not match the page being requested :/
Comment 6 Antoine "hashar" Musso (WMF) 2013-12-03 21:31:33 UTC
The Parsoid does queries to the MediaWiki API to get some content to render. One of the request is logged in api.log as:

 format=json action=visualeditor page=Marching_band paction=parse

I used ApiSandbox to reproduce that query:

http://en.wikipedia.beta.wmflabs.org/wiki/Special:ApiSandbox#action=visualeditor&format=json&page=Marching_band&paction=parse

The response contains among other things:

 http://en.wikipedia.org/wiki/Special:Redirect/revision/51845
 <title>Marching_band</title>
 Describe the new page here.

 "basetimestamp": "20120103034343",
 "starttimestamp": "20131203212539",
 "oldid": 51845

The redirection to old id 51845 yields page https://en.wikipedia.org/w/index.php?oldid=51845 which is the 'Pérez Prado' article.
Comment 7 Gabriel Wicke 2013-12-03 21:43:44 UTC
[13:41] <gwicke> parsoid is not using action=visualeditor
[13:42] <gwicke> I'd double-check that VE is actually using parsoidcache3
[13:42] <gwicke> and that the request goes to the right parsoid backend
Comment 8 Antoine "hashar" Musso (WMF) 2013-12-03 21:56:40 UTC
On deployment-parsoid2 , I have edited /usr/bin/parsoid to enable some log, namely the launch command is something like:

 sudo -E -u parsoid nohup node \
   /var/lib/parsoid/Parsoid/js/api/server.js \
   >/data/project/logs/parsoid-stdout.log \
   2>/data/project/logs/parsoid-error.log &

/data/project being the shared project directory, that might gives some clue.
Comment 9 Antoine "hashar" Musso (WMF) 2013-12-03 22:13:13 UTC
And it is fixed now!

Gabriel kindly answered all my newbie questions related to Parsoid architecture. Ended up confirming that Parsoid running on deployment-parsoid2 did query the production infrastructure despite a localsettings.js  claiming otherwise.

Roan showed up and noticed that /var/lib/parsoid/Parsoid points to the shared NFS directory (/data/project/apache/common-local/php-master/extensions/Parsoid/).  That one is autoupdated and did NOT contain the localsettings.js file

Roan copied the settings file, I restarted the server and now it seems to be serving the proper pages.

The root cause is https://gerrit.wikimedia.org/r/98014 from last Friday which I did not bother to verify :-(
Comment 10 Antoine "hashar" Musso (WMF) 2013-12-03 22:16:16 UTC
hopefully cleared parsoid cache using:


 deployment-parsoidcache3$ sudo varnishadm ban.url .

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links