Last modified: 2014-01-05 10:23:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59947, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57947 - VisualEditor: [Regression] "Switch to source editing" dies
VisualEditor: [Regression] "Switch to source editing" dies
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Highest critical
: VE-deploy-2013-12-05
Assigned To: James Forrester
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-03 20:12 UTC by Rummana Yasmeen
Modified: 2014-01-05 10:23 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rummana Yasmeen 2013-12-03 20:12:31 UTC
Steps to reproduce:

1.Click on Switch to source editing from the down menu for an article on betalabs

Observed Result:
Nothing happens.It does not switch to source editing from VE
Comment 1 Rummana Yasmeen 2013-12-03 20:14:11 UTC
Test Environment: production
Browser: Chrome Version 26.0.1410.65 &       FF 25
OS: MAC OS X 10. 8. 5 
Example Pagehttp://en.wikipedia.beta.wmflabs.org/wiki/Groel?veaction=edit
Comment 2 Rummana Yasmeen 2013-12-03 20:14:39 UTC
Sorry Test Environment should be betalabs in my previous comment.
Comment 3 James Forrester 2013-12-03 22:20:21 UTC
Bug 57926 is now fixed - does this still occur?
Comment 4 Rummana Yasmeen 2013-12-03 22:21:16 UTC
Yes, it is still occurring.
Comment 5 Gerrit Notification Bot 2013-12-03 22:36:58 UTC
Change 98989 had a related patch set uploaded by Jforrester:
Fix naked request for save dialog's summary in save

https://gerrit.wikimedia.org/r/98989
Comment 6 Gerrit Notification Bot 2013-12-03 22:42:26 UTC
Change 98989 merged by jenkins-bot:
Fix naked request for save dialog's summary in save

https://gerrit.wikimedia.org/r/98989
Comment 7 James Forrester 2013-12-03 22:45:20 UTC
This should now be fixed.
Comment 8 Rummana Yasmeen 2013-12-03 23:03:15 UTC
Verified the fix on beta labs 
Page:http://en.wikipedia.beta.wmflabs.org/wiki/New_page_on_latex
Comment 9 Jeff Hall 2013-12-04 00:02:49 UTC
Seeing something slightly odd after this fix was deployed to Betalabs - not sure this is Bad Thing, so not re-opening the bug at this point…

There are 2 pathways to switch from VE to wikitext, and they now navigate the user to different URLs (this didn't happen prior to the bug fix).

If you start in VE editing mode, and use the "Edit Source" tab to switch to wikitext, you end up at:

http://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:Oldjoe&action=edit

On other hand, if you start in VE editing mode and select "Switch to source editing" from the Page Settings drop-down, you end up at:

http://en.wikipedia.beta.wmflabs.org/wiki/User:Oldjoe?action=submit

Is this the intended behavior?
Comment 10 Rummana Yasmeen 2013-12-12 20:34:53 UTC
verified in production
Comment 11 James Forrester 2014-01-05 10:23:12 UTC
(In reply to comment #9)
> Seeing something slightly odd after this fix was deployed to Betalabs - not
> sure this is Bad Thing, so not re-opening the bug at this point…
> 
> There are 2 pathways to switch from VE to wikitext, and they now navigate the
> user to different URLs (this didn't happen prior to the bug fix).
> 
> If you start in VE editing mode, and use the "Edit Source" tab to switch to
> wikitext, you end up at:
> 
> http://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:
> Oldjoe&action=edit
> 
> On other hand, if you start in VE editing mode and select "Switch to source
> editing" from the Page Settings drop-down, you end up at:
> 
> http://en.wikipedia.beta.wmflabs.org/wiki/User:Oldjoe?action=submit
> 
> Is this the intended behavior?

The change to the primary entry point isn't explicitly intended, but I don't think it's the end of the world to push people towards the canonical (and simpler) URLs.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links