Last modified: 2013-12-14 21:49:32 UTC
Gerrit doesn't seem to have a public log of who adds or removes a reviewer. This can cause problems. Accountability and transparency require some kind of log. Upstream bug is <https://code.google.com/p/gerrit/issues/detail?id=1300>. Christian: not sure you're still working on Wikimedia's Gerrit installation, but if so... :-)
Ticket describes new functionality. Hence setting priority to enhancement.
(In reply to comment #0) > Christian: not sure you're still working on Wikimedia's Gerrit installation, > but if so... :-) The Analytics team is currently drowning in work, so there is no time left for me to work on gerrit :-( Upstream's solution is for ChangeScreen2, but since ChangeScreen2 is lacking in a few parts, I guess (hope) we'll not be upgrading to ChangeScreen2 soon. I agree that gerrit's current behaviour is not optimal. But I was under the impression that people are mostly civil and do not remove things secretly on purpose. Does this problem bite us badly/often?
Looks like an overkill to me.
(In reply to comment #2) > Upstream's solution is for ChangeScreen2, but since ChangeScreen2 is lacking > in a few parts, I guess (hope) we'll not be upgrading to ChangeScreen2 soon. > > I agree that gerrit's current behaviour is not optimal. > But I was under the impression that people are mostly civil and do not > remove things secretly on purpose. > > Does this problem bite us badly/often? Not often, but occasionally someone either intentionally or unintentionally removes a -2 from a change by removing and re-adding a reviewer, which can cause conflict without accountability. (In reply to comment #3) > Looks like an overkill to me. A separate log is probably overkill. Adding a comment is probably not. Gerrit already auto-adds comments in certain situations (e.g., when updating the commit message using the Gerrit graphical user interface).
