Last modified: 2013-12-06 16:43:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60023, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58023 - HTMLCacheUpdate should invalidate pages linking to any variant title of the given title if the variant title itself doesn't exist
HTMLCacheUpdate should invalidate pages linking to any variant title of the g...
Status: NEW
Product: MediaWiki
Classification: Unclassified
Language converter (Other open bugs)
1.23.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-05 09:33 UTC by Liangent
Modified: 2013-12-06 16:43 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Liangent 2013-12-05 09:33:09 UTC
Because when the "variant title" doesn't exist, LanguageConverter::findVariantLink() rewrites any link linking to the "variant title" to the "given title", so pages containing such links need cache invalidation too.

More consideration: HTMLCacheUpdate seems not only for pagelinks, and findVariantLink is applied on some, but not all, other links. IIRC what works includes pagelinks, templatelinks and categorylinks. We may want to decide whether to add a new argument to HTMLCacheUpdate indicating to include variant titles or not, or switch based on $table, or just change callers to issue multiple HTMLCacheUpdate calls when variant invalidation is needed.

Note: about page creation and deletion, this is only needed for creation, as pagelinks table is already affected by findVariantLink's rewrite to use "given title" during parsing when that page exists.

Bug appearance on zhwiki:
1. Create [[page]] containing "[[測試]]"
2. Create [[测试]] with some content
3. [[page]] appears to contain a red link now, but a purge or null edit turns it to be blue, pointing to [[测试]]
Comment 1 Liangent 2013-12-05 09:34:27 UTC
cc'ing the inventor of HTMLCacheUpdate to give some idea about the "more consideration" part.
Comment 2 Bawolff (Brian Wolff) 2013-12-06 16:43:39 UTC
At first glance, I personally think multiple HTMLCacheUpdate's might be the way to go.

Given that creation of a variant causes things linking to the other variant to change what pages they link to (and thus the links table), perhaps a non-recursive linksupdate would be in order for this situation.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links