Last modified: 2013-12-13 20:22:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60054, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58054 - auto-external links terminate differently than the php parser
auto-external links terminate differently than the php parser
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Gabriel Wicke
:
: 57520 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-05 21:38 UTC by Erik Bernhardson
Modified: 2013-12-13 20:22 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Erik Bernhardson 2013-12-05 21:38:55 UTC
In the php parser the wikitext "(http://www.google.com)" results in:

    (<a class="external free" href="https://bugzilla.wikimedia.org/show_bug.cgi?id=57451">https://bugzilla.wikimedia.org/show_bug.cgi?id=57451</a>)

Running the same content through parsoid results in:

    (<a rel="mw:ExtLink" href="http://www.google.com)" data-parsoid='{"stx":"url","dsr":[1,23,0,0]}'>http://www.google.com)</a>

The final parenthesis should be outside the anchor, rather than included in the url.
Comment 1 Gerrit Notification Bot 2013-12-06 00:47:22 UTC
Change 99587 had a related patch set uploaded by GWicke:
Bug 58054: Implement URL link parenthesis heuristic

https://gerrit.wikimedia.org/r/99587
Comment 2 Gerrit Notification Bot 2013-12-06 18:36:11 UTC
Change 99587 merged by jenkins-bot:
Bug 58054: Implement URL link parenthesis heuristic

https://gerrit.wikimedia.org/r/99587
Comment 3 Gabriel Wicke 2013-12-06 18:37:23 UTC
Scheduled for deployment on Monday.
Comment 4 spage 2013-12-11 04:31:30 UTC
*** Bug 57520 has been marked as a duplicate of this bug. ***
Comment 5 Gerrit Notification Bot 2013-12-13 19:54:19 UTC
Change 101284 had a related patch set uploaded by GWicke:
Merge "Bug 58054: Implement URL link parenthesis heuristic"

https://gerrit.wikimedia.org/r/101284
Comment 6 Gerrit Notification Bot 2013-12-13 19:55:54 UTC
Change 101341 had a related patch set uploaded by GWicke:
Bug 58054: Implement URL link parenthesis heuristic

https://gerrit.wikimedia.org/r/101341
Comment 7 Gerrit Notification Bot 2013-12-13 19:56:42 UTC
Change 101284 merged by GWicke:
Merge "Bug 58054: Implement URL link parenthesis heuristic"

https://gerrit.wikimedia.org/r/101284
Comment 8 Gerrit Notification Bot 2013-12-13 19:56:46 UTC
Change 101341 merged by GWicke:
Bug 58054: Implement URL link parenthesis heuristic

https://gerrit.wikimedia.org/r/101341

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links