Last modified: 2014-02-27 01:38:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60055, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58055 - Going to next image, then previous, quickly enough, will cause the load callbacks to fire and give you the next image
Going to next image, then previous, quickly enough, will cause the load callb...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
MultimediaViewer (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-05 21:45 UTC by Mark Holmquist
Modified: 2014-02-27 01:38 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mark Holmquist 2013-12-05 21:45:40 UTC
e.g. I'm on image 1, I go to load image 2 but quickly move back to image 1. When the image 2 load callback fires, it replaces image 1 (which I'm viewing), replaces the metadata, and fails to update the URL. Going to the next image brings me to image 2 again, which is confusing.

Solution: Probably clear all callbacks in this case, somehow. Or check that the image we're loading in the callbacks is the image we're currently on. Or use nonces for image load callbacks so we know which one to listen to.
Comment 2 Gerrit Notification Bot 2014-02-26 10:51:32 UTC
Change 115591 had a related patch set uploaded by Gilles:
Bugfixes and improvements for the progress bar

https://gerrit.wikimedia.org/r/115591
Comment 3 Gerrit Notification Bot 2014-02-27 01:35:29 UTC
Change 115591 merged by jenkins-bot:
Bugfixes and improvements for the progress bar

https://gerrit.wikimedia.org/r/115591
Comment 4 Tisza Gergő 2014-02-27 01:38:25 UTC
Can't reproduce anymore, hash, image and metadata are in sync no matter how quickly I page, and I haven't non-fully-loaded images either.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links