Last modified: 2014-10-15 00:12:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60057, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58057 - Edit notice saying that changes must be reviewed appears even when the user has autoreview rights
Edit notice saying that changes must be reviewed appears even when the user h...
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 57835 59153 (view as bug list)
Depends on:
Blocks: ve-nonenglish
  Show dependency treegraph
 
Reported: 2013-12-05 22:01 UTC by Bartosz Dziewoński
Modified: 2014-10-15 00:12 UTC (History)
13 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bartosz Dziewoński 2013-12-05 22:01:15 UTC
Flaggedrevs edit notice saying that you don't have reviewer rights appears even when you do have them. This is quite annoying since it's rather long.

Reported at https://pl.wikipedia.org/w/index.php?title=Wikipedia:Kawiarenka/Kwestie_techniczne&oldid=38078001#Komunikat_dla_os.C3.B3b_niemaj.C4.85cych_statusu_redaktora
Comment 1 Alex Monk 2014-02-12 01:57:27 UTC
Does it actually say that you don't have reviewer rights? Or is it the "Your changes will be displayed to readers once an authorised user accepts them. (help)" one that implies it?

If so, this is correctly shown when there are any unapproved revisions on a page - someone (possibly including the current user) will need to manually approve any new changes even if the current user would normally be able to autoreview (obviously autoreview does not occur if there are outstanding unreviewed changes).
Comment 2 Alex Monk 2014-02-14 01:52:20 UTC
Seems invalid.
Comment 3 Bartosz Dziewoński 2014-02-14 10:51:47 UTC
Not really.

The notice should not be shown for users whose edits do not need to be reviewed – that is the behavior of the wikitext editor.
Comment 4 Alex Monk 2014-02-14 16:38:42 UTC
So what exactly is happening differently to the wikitext editor here then?

As far as I can tell FR is behaving properly by showing this notice when there are changes waiting for review on the current page (even if the user could review their own change).
Comment 5 Bartosz Dziewoński 2014-02-14 18:20:40 UTC
The notice appears, always, regardless of everything.

It should be only shown when the user can't autoreview the changes they're about to make, just like in the wikitext editor.
Comment 6 Alex Monk 2014-02-14 18:43:07 UTC
Can't replicate this issue.
Comment 7 James Forrester 2014-02-27 19:21:42 UTC
*** Bug 59153 has been marked as a duplicate of this bug. ***
Comment 8 Bartosz Dziewoński 2014-04-19 13:13:55 UTC
*** Bug 57835 has been marked as a duplicate of this bug. ***
Comment 9 James Forrester 2014-10-14 23:43:43 UTC
Marking as WFM given lack of replication steps.
Comment 10 John Mark Vandenberg 2014-10-15 00:08:34 UTC
The problem definitely occurs, still occurs, but also occurs in the source editor.  It is just that the problem is more pronounced in the Visual Editor.

The message might need to be split into two - one for people with the rights to approve changes, and another for people whose edits will be queued for review.
Hopefully the latter message is shorter.

Alternatively there is another message (on de.wp) "Notice: Some of the pending changes affect the area of the page you are editing." , which could be split into two, so that editors with review rights see "Notice: There are pending changes which will be automatically sighted if your changes are saved."
Comment 11 James Forrester 2014-10-15 00:12:28 UTC
Ah, right. Marking as such.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links