Last modified: 2013-12-10 22:46:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60069, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 58069 - Respect x-forwarded-for header in Wikimania Scholarships application
Respect x-forwarded-for header in Wikimania Scholarships application
Status: RESOLVED WONTFIX
Product: Wikimedia
Classification: Unclassified
Wikimania Scholarships (Other open bugs)
wmf-deployment
All All
: Normal normal (vote)
: ---
Assigned To: Bryan Davis
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-12-06 01:39 UTC by Bryan Davis
Modified: 2013-12-10 22:46 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bryan Davis 2013-12-06 01:39:45 UTC 
The application attempts to capture the submitting user's ip address to associate with their scholarship request. The current application logic captures $_SERVER['REMOTE_ADDR'] which will be mostly useless in production as the application will be proxied via an SSL terminator proxy and Varnish.
Comment 1 Bryan Davis 2013-12-06 01:42:21 UTC 
It wouldn't be a horrible idea to make sure that the application will properly store IPv6 addresses in the database at the same time this issue is addressed.
Comment 2 Gerrit Notification Bot 2013-12-09 21:19:17 UTC 
Change 100440 had a related patch set uploaded by BryanDavis:
Respect X-Forwarded-For header when present

https://gerrit.wikimedia.org/r/100440
Comment 3 Gerrit Notification Bot 2013-12-10 22:43:35 UTC 
Change 100440 abandoned by BryanDavis:
Respect X-Forwarded-For header when present

Reason:
Not needed due to Bug 58295.

https://gerrit.wikimedia.org/r/100440
Comment 4 Bryan Davis 2013-12-10 22:44:39 UTC 
Remote IP will no longer be stored due to Bug 58295
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links