Last modified: 2013-12-11 00:14:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60107, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 58107 - Multimedia Viewer: Keyboard shortcut to activate MV active inside VisualEditor
Multimedia Viewer: Keyboard shortcut to activate MV active inside VisualEditor
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
MultimediaViewer (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Mark Holmquist
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-12-06 18:57 UTC by James Forrester
Modified: 2013-12-11 00:14 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description James Forrester 2013-12-06 18:57:48 UTC 
When ve-activated class is set on the body, it would be lovely to deactivate this feature as it's rather irritating. Think it's Shift+cursor or Ctrl+Shift+cursor or something similar?
Comment 1 Mark Holmquist 2013-12-06 19:00:24 UTC 
This may be because we don't clear keydown listener events on closing the viewer. Patch incomiiiiing
Comment 2 Gerrit Notification Bot 2013-12-06 20:16:11 UTC 
Change 99722 had a related patch set uploaded by MarkTraceur:
Move clearInterface things to mw.LightboxInterface

https://gerrit.wikimedia.org/r/99722
Comment 3 Gerrit Notification Bot 2013-12-10 01:41:20 UTC 
Change 99722 merged by jenkins-bot:
Move clearInterface things to mw.LightboxInterface

https://gerrit.wikimedia.org/r/99722
Comment 4 Mark Holmquist 2013-12-10 01:41:49 UTC 
Bam. Done. Thanks.
Comment 5 Gerrit Notification Bot 2013-12-10 19:16:05 UTC 
Change 100611 had a related patch set uploaded by MarkTraceur:
Move clearInterface things to mw.LightboxInterface

https://gerrit.wikimedia.org/r/100611
Comment 6 Gerrit Notification Bot 2013-12-11 00:06:30 UTC 
Change 100611 merged by MarkTraceur:
Move clearInterface things to mw.LightboxInterface

https://gerrit.wikimedia.org/r/100611
Comment 7 Mark Holmquist 2013-12-11 00:14:42 UTC 
We backported this fix to 1.23wmf6, so mediawiki.org and all sister sites should be fixed now.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links