Last modified: 2014-06-28 20:51:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60110, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58110 - Add more VisualEditor tests via CloudBees jobs for OSes beyond Linux
Add more VisualEditor tests via CloudBees jobs for OSes beyond Linux
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Quality Assurance (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Chris McMahon
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-06 19:10 UTC by Jeff Hall
Modified: 2014-06-28 20:51 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jeff Hall 2013-12-06 19:10:30 UTC
Per a request from James F, we should start to expand the selection of environments (OS and browser combinations) that Visual Editor automated tests run via CloudBees.  

For example, add a "Internet Explorer 10 on Windows 8" test, and related variations that CloudBees/SauceLabs can accommodate.

Per Chris M, a good way to get started is to copy the existing "Selenium" template in CloudBees and figure out what we need to do to add Windows into the mix.
Comment 1 Jeff Hall 2013-12-06 20:48:33 UTC
Created a new test template to mess around with:

https://wmf.ci.cloudbees.com/template/81889c2c-ef15-4fad-b39b-8256eb9e841a/
Comment 2 Jeff Hall 2013-12-06 21:50:26 UTC
In addition to the new template in CloudBees, I think we'll need to expand the config.yml file in the VisualEditor repo:

https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/test/browser/config/config.yml

For example, our existing "firefox" profile is hard-coded to Firefox version 23 on Linux, so we'll need to add more entries for Firefox on Windows 8, etc.
Comment 3 Željko Filipin 2013-12-10 19:27:09 UTC
#1 I would hesitate to add more Jenkins jobs until existing ones[1] are rock solid (meaning there were no failures in a week or so).

#2 The entire config folder will soon(tm) be moved to mediawiki-selenium gem[2]. We should probably rename config.yml to browsers.yml (since it no longer has any other information, only browsers) and expand the number of combinations, like Wikibase has already done[3]

1: https://wmf.ci.cloudbees.com/view/r-ve/
2: https://gerrit.wikimedia.org/r/#/c/90560
3: https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/tests/browser/config/browsers.yml
Comment 4 Jeff Hall 2013-12-11 00:31:00 UTC
(In reply to comment #3)
> #1 I would hesitate to add more Jenkins jobs until existing ones[1] are rock
> solid (meaning there were no failures in a week or so).
> 
> #2 The entire config folder will soon(tm) be moved to mediawiki-selenium
> gem[2]. We should probably rename config.yml to browsers.yml (since it no
> longer has any other information, only browsers) and expand the number of
> combinations, like Wikibase has already done[3]
> 
> 1: https://wmf.ci.cloudbees.com/view/r-ve/
> 2: https://gerrit.wikimedia.org/r/#/c/90560
> 3:
> https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/tests/
> browser/config/browsers.yml

Thanks Željko - I agree with both of your points, especially #1, which is an ongoing problem area (which I am working on!)
Comment 5 Željko Filipin 2014-01-29 11:56:43 UTC
(In reply to comment #3)
> #2 The entire config folder will soon(tm) be moved to mediawiki-selenium
> gem[2]. We should probably rename config.yml to browsers.yml (since it no
> longer has any other information, only browsers) and expand the number of
> combinations, like Wikibase has already done[3]

config.yml is now moved to mediawiki-selenium gem. Feel free to expand the number of browser/OS combinations in the gem.
Comment 6 Jeff Hall 2014-02-03 19:27:29 UTC
Per a chat with Rummana, the priority test environments to add (via CloudBees and Sauce Labs) are:

1) Chrome on Windows XP
2) Firefox on Windows XP
Comment 7 Gerrit Notification Bot 2014-02-03 19:44:58 UTC
Change 110980 had a related patch set uploaded by Jhall:
Adding new priority Windows browser tests for VisualEditor.

https://gerrit.wikimedia.org/r/110980
Comment 8 Jeff Hall 2014-02-03 19:47:19 UTC
Setting bug status back to resolved since the 110980 Gerrit patch is a first step only; if that change works out well, we can add additional (browser + OS) combinations to work towards eventually resolving this bug.
Comment 9 Gerrit Notification Bot 2014-02-06 17:29:51 UTC
Change 110980 abandoned by Jhall:
Adding new priority Windows browser tests for VisualEditor.

Reason:
Abandoning this change per a discussion between Chris, Željko and myself.  We have decided to implement new (browser + OS) combinations for use with SauceLabs via environment variable values rather than via hard-coded amendments to the mediawiki-selenium gem itself.

https://gerrit.wikimedia.org/r/110980
Comment 10 Jeff Hall 2014-02-26 05:26:58 UTC
Tests have been setup in CloudBees at the following locations:

1) Chrome on Windows XP: https://wmf.ci.cloudbees.com/view/ve/job/VisualEditor-en.wikipedia.beta.wmflabs.org-windows_xp-chrome/
2) Firefox on Windows XP: https://wmf.ci.cloudbees.com/view/ve/job/VisualEditor-en.wikipedia.beta.wmflabs.org-windows_xp-firefox/
Comment 11 Željko Filipin 2014-03-03 14:25:30 UTC
Jeff, where are the jobs configured? I do not see them anywhere. This is where I have looked:

https://github.com/zeljkofilipin/jenkins-job-builder-config
https://gerrit.wikimedia.org/r/#/admin/projects/integration/jenkins-job-builder-config

Did you create the jobs manually?
Comment 13 James Forrester 2014-06-28 20:51:47 UTC
Yes.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links