Last modified: 2013-12-10 00:12:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60130, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58130 - Rewrite Template:Interval in Lua
Rewrite Template:Interval in Lua
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
wmf-deployment
All All
: Unprioritized enhancement (vote)
: ---
Assigned To: Theopolisme
http://www.google-melange.com/gci/tas...
gci2013
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-06 22:44 UTC by Quim Gil
Modified: 2013-12-10 00:12 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Quim Gil 2013-12-06 22:44:51 UTC
According to https://en.wikipedia.org/wiki/Wikipedia:Lua/To_do [[w:Template:Interval]] must be rewritten in Lua.

This is a bug report created to follow the progress. A related Google Code-in task will be created soon.
Comment 1 Theopolisme 2013-12-08 02:57:01 UTC
Okay, sandbox module created at https://en.wikipedia.org/wiki/Module:Sandbox/Theopolisme

Testcases are at https://en.wikipedia.org/wiki/Template:Interval/testcases (under "Sandbox template").

Unsure as to next steps -- should I post something at [[w:WT:Lua]] to solicit reviewers? Move it to Module:Interval? Prod at some of my IRC friends? ;) Or is there a different procedure I should follow?
Comment 2 Quim Gil 2013-12-08 05:57:53 UTC
Bravo!

This is the first Lua template related GCI task, and we are polishing the process as we go.

Templates discussion and revision happen mostly in wiki pages, not in the Bugzilla-Gerrit tandem that we use in other coding tasks.

Your template looks good to (inexperienced) me, and your test results are correct. Therefore, as soon as you share your work at https://en.wikipedia.org/wiki/Wikipedia:Lua/To_do where Template:Interval we can close this task. 

As we have done with other GCI tasks, you are encouraged to follow possible feedback, this time coming via wiki pages. If your module is considered good, you might be asked to update the current template based on wikitext, and the /doc subpage if there is anything to do there.

PS: I'm also CCing Brad, my usual contact for anything Lua, just in case he wants to review your template.
Comment 3 Theopolisme 2013-12-08 06:12:46 UTC
I've moved the code to [[w:Module:Interval]] and commented at (and watchlisted) the to-do page.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links