Last modified: 2014-01-31 01:37:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60136, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58136 - VisualEditor: If copying from one VE instance to another, pasted links result in broken wikitext (external URL, internal link format)
VisualEditor: If copying from one VE instance to another, pasted links result...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: Normal major
: VE-deploy-2014-01-30
Assigned To: Ed Sanders
:
: 59216 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-07 00:32 UTC by Rummana Yasmeen
Modified: 2014-01-31 01:37 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rummana Yasmeen 2013-12-07 00:32:28 UTC
Steps to reproduce:


1.Open the editor for a page which contains a link
2.Copy the link
3.Now open VE for another article and paste the copied link onto it
4.Save the page


Observed Result:

The copied link appears as a plain text on the read mode where as in the Edit Source/Edit mode it appears as a link
Comment 1 Rummana Yasmeen 2013-12-07 00:33:43 UTC
Page: Observe the second "Edit source" text on the page:
http://en.wikipedia.beta.wmflabs.org/wiki/To_edit_source

Test Environment: Betalabs
Browser: Chrome Version 26.0.1410.65
OS: MAC OS X 10. 8. 5
Comment 2 Gerrit Notification Bot 2013-12-09 19:50:50 UTC
Change 100422 had a related patch set uploaded by Esanders:
Only strip style attributes on rich paste from VE

https://gerrit.wikimedia.org/r/100422
Comment 3 Gerrit Notification Bot 2013-12-09 22:58:11 UTC
Change 100493 had a related patch set uploaded by Jforrester:
Only strip style attributes on rich paste from VE

https://gerrit.wikimedia.org/r/100493
Comment 4 Gerrit Notification Bot 2013-12-09 22:59:07 UTC
Change 100422 merged by jenkins-bot:
Only strip style attributes on rich paste from VE

https://gerrit.wikimedia.org/r/100422
Comment 5 Gerrit Notification Bot 2013-12-09 23:49:21 UTC
Change 100493 merged by jenkins-bot:
Only strip style attributes on rich paste from VE

https://gerrit.wikimedia.org/r/100493
Comment 6 James Forrester 2013-12-09 23:55:29 UTC
A fix for this is going out in about 4 minutes' time. Sorry for the disruption.
Comment 7 Rummana Yasmeen 2013-12-11 19:29:22 UTC
Verified in betalabs
Comment 8 Rummana Yasmeen 2013-12-14 01:21:07 UTC
verified the fix in test2:https://test2.wikipedia.org/w/index.php?title=13th_december
Comment 9 Rummana Yasmeen 2013-12-18 20:18:06 UTC
This issue is still occurring for following case:

1.Open the editor for a page "A" which contains a link to another page "B"
2.Copy the link and Paste it into "B"
3.Save the page

Observed Result:
The link to the same page is appearing as plain text in the read mode.

Found in :http://en.wikipedia.beta.wmflabs.org/wiki/The_paste_destination
Comment 10 Gerrit Notification Bot 2014-01-06 17:11:47 UTC
Change 105706 had a related patch set uploaded by Esanders:
Always use absolute URLs in external links in the clipboard

https://gerrit.wikimedia.org/r/105706
Comment 11 Gerrit Notification Bot 2014-01-08 14:38:38 UTC
Change 106253 had a related patch set uploaded by Esanders:
Always use absolute URLs in external links in the clipboard

https://gerrit.wikimedia.org/r/106253
Comment 12 Gerrit Notification Bot 2014-01-13 19:38:43 UTC
Change 106253 merged by jenkins-bot:
Always use absolute URLs in external links in the clipboard

https://gerrit.wikimedia.org/r/106253
Comment 13 Gerrit Notification Bot 2014-01-15 22:27:30 UTC
Change 105706 merged by jenkins-bot:
Support external links in MWInternalLinkAnnotation

https://gerrit.wikimedia.org/r/105706
Comment 14 Rummana Yasmeen 2014-01-16 19:45:13 UTC
The issue described later in this bug still exists in test.Again giving the steps here:
This issue is still occurring for following case:

1.Open the editor for a page "A" which contains a link to another page "B"
2.Copy the link and Paste it into "B"
3.Save the page

Observed Result:
The link to the same page is appearing as plain text in the read mode.
Comment 15 Rummana Yasmeen 2014-01-16 19:46:49 UTC
The testing environment is test2, wmf 11.
Broswer:Chrome/Firefox
Comment 16 James Forrester 2014-01-18 05:49:48 UTC
*** Bug 59216 has been marked as a duplicate of this bug. ***
Comment 17 Ed Sanders 2014-01-21 15:03:10 UTC
The last fix was merged on 15th Jan. The test environment you point to says it is running code from 14th Jan. Please re-open if broken with master.
Comment 18 Rummana Yasmeen 2014-01-21 21:21:22 UTC
Ed, I tested it on 16th december(Last thursday) after the deployment on test2.So it should have been merged to test2 by that time right? Also, I am still getting it on test2
Comment 19 Rummana Yasmeen 2014-01-21 22:31:24 UTC
Sorry 16th January :)
Comment 20 Gerrit Notification Bot 2014-01-22 20:07:33 UTC
Change 108954 had a related patch set uploaded by Esanders:
Relativise URLs against target document

https://gerrit.wikimedia.org/r/108954
Comment 21 Gerrit Notification Bot 2014-01-22 21:00:01 UTC
Change 108953 had a related patch set uploaded by Krinkle:
Resolve URLs against correct document when copying.

https://gerrit.wikimedia.org/r/108953
Comment 22 James Forrester 2014-01-23 01:54:03 UTC
Possibly now fixed. Hopefully.
Comment 23 Gerrit Notification Bot 2014-01-23 02:58:52 UTC
Change 108954 merged by jenkins-bot:
Relativise URLs against target document

https://gerrit.wikimedia.org/r/108954
Comment 24 Rummana Yasmeen 2014-01-31 01:37:25 UTC
Verified the fix on test 2

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links