Last modified: 2014-02-12 23:47:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60239, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 58239 - Opening notifications overlay scrolls page to the bottom
Opening notifications overlay scrolls page to the bottom
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
beta (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
: 58298 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-12-09 22:08 UTC by Juliusz Gonera
Modified: 2014-02-12 23:47 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Juliusz Gonera 2013-12-09 22:08:44 UTC 
In beta, if you open notifications overlay, the page is scrolled to the bottom. This is caused by div#notifications which is used for toasts.

Proposed solution: start using a prefix for route hashes. Not sure if hashbang (#!) is a good one, since those URLs are not meant to be crawled anyway.
Comment 1 Bingle 2013-12-09 22:10:30 UTC 
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1491
Comment 2 Jon 2013-12-09 22:28:53 UTC 
Ahh I kept seeing this and thought i was going mad - now it all makes sense. Thanks for identifying the problem! :)

I would suggest not using ! but maybe prefixing with the '/' character since these can never be present in ID attributes thus more future proof

e.g. #/notifications
Comment 3 Jon 2013-12-10 23:44:10 UTC 
*** Bug 58298 has been marked as a duplicate of this bug. ***
Comment 4 Gerrit Notification Bot 2013-12-11 17:52:49 UTC 
Change 100811 had a related patch set uploaded by Jdlrobson:
Prefix notifications with '/'

https://gerrit.wikimedia.org/r/100811
Comment 5 Gerrit Notification Bot 2013-12-13 01:25:33 UTC 
Change 100811 merged by jenkins-bot:
Prefix notifications with '/'

https://gerrit.wikimedia.org/r/100811
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links