Last modified: 2013-12-30 10:10:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60242, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58242 - VisualEditor: MWReferenceList throws exception when pasted with a reference into a new document
VisualEditor: MWReferenceList throws exception when pasted with a reference i...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: High major
: VE-deploy-2013-12-12
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-09 23:02 UTC by Rummana Yasmeen
Modified: 2013-12-30 10:10 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
The Errors (110.44 KB, image/png)
2013-12-09 23:02 UTC, Rummana Yasmeen
Details

Description Rummana Yasmeen 2013-12-09 23:02:25 UTC
Created attachment 14044 [details]
The Errors

Steps to reproduce:

1.Open an editor which has a text with reference and the reflist
For example:

text with reference[1]
↑ ref

2.Try to paste it into a different page

Observed Result:
Uncaught TypeError: Cannot read property 'length' of undefined appears and nothing gets pasted.

However the "Save Page" button is active and clicking on that gives the error:
Uncaught TypeError: Cannot call method 'getRange' of undefined
Comment 1 Rummana Yasmeen 2013-12-09 23:04:48 UTC
Test Environment: betalabs
Browser: Chrome Version 26.0.1410.65 
OS: MAC OS X 10. 8. 5 
Example Page with reference and reflist: :http://en.wikipedia.beta.wmflabs.org/wiki/Bold?veaction=edit
Comment 2 Rummana Yasmeen 2013-12-12 22:25:25 UTC
I am escalating this issue, because it is now reproducible in production:https://en.wikipedia.org/wiki/ and after this action copy-paste does not work from one VE to another.
Comment 3 Rummana Yasmeen 2013-12-12 22:51:19 UTC
In production, go to this page :https://en.wikipedia.org/w/index.php?title=User:RYasmeen_%28WMF%29/12th_december&veaction=edit

Copy the last reference along with reference list and try to paste it into another page.
And after that nothing can be copied into the other VE
Comment 4 Gerrit Notification Bot 2013-12-12 23:03:16 UTC
Change 101131 had a related patch set uploaded by Esanders:
Check InternalList node exists when rendering MWReferenceList

https://gerrit.wikimedia.org/r/101131
Comment 5 Gerrit Notification Bot 2013-12-12 23:13:40 UTC
Change 101133 had a related patch set uploaded by Catrope:
Check InternalList node exists when rendering MWReferenceList

https://gerrit.wikimedia.org/r/101133
Comment 6 Gerrit Notification Bot 2013-12-12 23:13:44 UTC
Change 101131 merged by jenkins-bot:
Check InternalList node exists when rendering MWReferenceList

https://gerrit.wikimedia.org/r/101131
Comment 7 Gerrit Notification Bot 2013-12-12 23:13:56 UTC
Change 101134 had a related patch set uploaded by Catrope:
Check InternalList node exists when rendering MWReferenceList

https://gerrit.wikimedia.org/r/101134
Comment 8 Gerrit Notification Bot 2013-12-12 23:14:23 UTC
Change 101134 merged by Catrope:
Check InternalList node exists when rendering MWReferenceList

https://gerrit.wikimedia.org/r/101134
Comment 9 Gerrit Notification Bot 2013-12-12 23:14:36 UTC
Change 101133 merged by Catrope:
Check InternalList node exists when rendering MWReferenceList

https://gerrit.wikimedia.org/r/101133
Comment 10 James Forrester 2013-12-12 23:18:31 UTC
Now being deployed on wmf6 and wmf7.
Comment 11 Rummana Yasmeen 2013-12-13 00:14:49 UTC
Checked the fix in production.The issue specified in this bug is fixed.Reference is getting pasted with reference list and the subsequent elements are getting copy-pasted properly.But still there is a problem with pasting reference :(

The reference is getting copied as an empty <ref/> tags and on edit mode it says 
The reference is defined in a template or other generated block and for now can only be edited in source mode.

In read mode: There is an error:Cite error: The opening <ref> tag is malformed or has a bad name (see the help page).

Should I create a different issue ticket for that?
Comment 12 Ed Sanders 2013-12-13 00:21:25 UTC
Yes please. Give steps with wikitext to reproduce.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links