Last modified: 2014-11-17 09:21:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60249, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58249 - LocalisationUpdate doesn't work with .i18n.php shims for new-style .json messages
LocalisationUpdate doesn't work with .i18n.php shims for new-style .json mess...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
unspecified
All All
: High normal with 2 votes (vote)
: ---
Assigned To: Niklas Laxström
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-10 02:33 UTC by Brad Jorsch
Modified: 2014-11-17 09:21 UTC (History)
12 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brad Jorsch 2013-12-10 02:33:29 UTC
Failed to read file: exception 'Exception' with message 'Expected open tag, whitespace, or variable., got T_STRING ('array_map')' in /a/common/php-1.23wmf6/extensions/LocalisationUpdate/QuickArrayReader.php:135
Stack trace:
#0 /a/common/php-1.23wmf6/extensions/LocalisationUpdate/QuickArrayReader.php(119): QuickArrayReader->except(Array, 'open tag, white...')
#1 /a/common/php-1.23wmf6/extensions/LocalisationUpdate/LocalisationUpdate.class.php(528): QuickArrayReader->__construct('<?php $messages...')
#2 /a/common/php-1.23wmf6/extensions/LocalisationUpdate/LocalisationUpdate.class.php(313): LocalisationUpdate::parsePHP('$messages = arr...', 'messages')
#3 /a/common/php-1.23wmf6/extensions/LocalisationUpdate/LocalisationUpdate.class.php(435): LocalisationUpdate::loadFilesToCompare('VisualEditor', '/var/lib/l10nup...', '/a/common/php-1...', false, false)
#4 /a/common/php-1.23wmf6/extensions/LocalisationUpdate/LocalisationUpdate.class.php(153): LocalisationUpdate::compareExtensionFiles('VisualEditor', '/var/lib/l10nup...', '/a/common/php-1...', false)
#5 /a/common/php-1.23wmf6/extensions/LocalisationUpdate/LocalisationUpdate.class.php(113): LocalisationUpdate::updateExtensionMessages('/a/common/php-1...', 'VisualEditor', false, '/var/lib/l10nup...')
#6 /a/common/php-1.23wmf6/extensions/LocalisationUpdate/update.php(34): LocalisationUpdate::updateMessages(Array)
#7 /a/common/multiversion/MWScript.php(97): require_once('/a/common/php-1...')
#8 {main}
Failed to parse /var/lib/l10nupdate/mediawiki/extensions/VisualEditor/VisualEditor.i18n.php
Comment 1 Gerrit Notification Bot 2013-12-10 02:41:26 UTC
Change 100527 had a related patch set uploaded by Jforrester:
Revert "Shim for VisualEditor.i18n.php that reads JSON blobs"

https://gerrit.wikimedia.org/r/100527
Comment 2 Gerrit Notification Bot 2013-12-10 02:44:18 UTC
Change 100527 merged by jenkins-bot:
Revert "Shim for VisualEditor.i18n.php that reads JSON blobs"

https://gerrit.wikimedia.org/r/100527
Comment 3 Roan Kattouw 2013-12-11 00:32:57 UTC
(In reply to comment #2)
> Change 100527 merged by jenkins-bot:
> Revert "Shim for VisualEditor.i18n.php that reads JSON blobs"
> 
> https://gerrit.wikimedia.org/r/100527
This has been reintroduced, because despite the scary-looking exception, it didn't actually break LU for anything other than VE.
Comment 4 Siebrand Mazeland 2013-12-19 19:42:03 UTC
This issue is tracked in mingle at https://wikimedia.mingle.thoughtworks.com/projects/language_engineering/cards/3897
Comment 6 Amir E. Aharoni 2014-03-22 20:24:41 UTC
Is this fixed now?
Comment 7 James Forrester 2014-03-22 20:31:41 UTC
(In reply to Amir E. Aharoni from comment #6)
> Is this fixed now?

I believe it will be fixed by Gerrit change #119944 when that is merged and deployed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links