Last modified: 2014-06-24 15:01:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60274, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58274 - Implement an order-aware MapDiffer
Implement an order-aware MapDiffer
Status: REOPENED
Product: MediaWiki extensions
Classification: Unclassified
Diff (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Nobody - You can work on this!
backlog
:
Depends on:
Blocks: 57918
  Show dependency treegraph
 
Reported: 2013-12-10 14:31 UTC by tobias.gritschacher
Modified: 2014-06-24 15:01 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description tobias.gritschacher 2013-12-10 14:31:17 UTC

    
Comment 1 Daniel Kinzler 2013-12-10 14:55:12 UTC
One problem with implementing this is that following the naive approach (representing a change in order as a remove and an insert operation), both such operations would have the same key in the (Map)Diff, so one would override the other. Also, for the insert operation, it would need some context specifying *where* to insert it.

An alternative approach is to represent the order explicitly as a list of keys, and attach that list as an extra field to the MapDiff.

Note that the class tree based in the Diff class contains some overburdened and some deprecated classes. Some refactoring may be in order. 

Also, care must be taken to allow for reliably application of Diffs as patches.
Comment 2 Andre Klapper 2014-01-22 16:09:09 UTC
Wikidata crew: This has been highest priority since 2013-12-10. Any news here?
Comment 3 Jeroen De Dauw 2014-03-01 22:26:52 UTC
Now at https://github.com/wmde/Diff/issues/4
Comment 4 tobias.gritschacher 2014-05-16 12:22:11 UTC
Reopen this to not forget it when not following the issues on GitHub.
Comment 5 Andre Klapper 2014-06-02 10:25:32 UTC
(In reply to tobias.gritschacher from comment #4)
> Reopen this to not forget it when not following the issues on GitHub.

Is this ticket still "highest priority" which was set half a year ago?
Comment 6 Andre Klapper 2014-06-24 00:20:59 UTC
(In reply to tobias.gritschacher from comment #4)
> Reopen this to not forget it when not following the issues on GitHub.

Is this ticket still "highest priority" which was set half a year ago? If yes, we might have different interpretations of highest priority. ;)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links