Last modified: 2014-08-28 18:01:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60296, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58296 - Apply mw.ui button styles to wpSave, wpPreview, and wpDiff
Apply mw.ui button styles to wpSave, wpPreview, and wpDiff
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Deepali Jain
: design, easy
Depends on: 55554 58297
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-10 22:57 UTC by Steven Walling
Modified: 2014-08-28 18:01 UTC (History)
15 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Steven Walling 2013-12-10 22:57:52 UTC
MediaWiki UI has matured enough that, while it may change in the future, it's being applied to essential parts of Core like login, signup, and search buttons. 

At this point I see no reason why we shouldn't apply mw.ui button styles to save, preview, and show changes. I propose that we make save an .mw-ui-button.mw-ui-primary button (so the blue color) while leaving Preview and Show changes grey but increasing the sizing to match Save.
Comment 1 Steven Walling 2013-12-10 23:00:37 UTC
(In reply to comment #0)
> MediaWiki UI has matured enough that, while it may change in the future, it's
> being applied to essential parts of Core like login, signup, and search
> buttons. 

I forgot to note: they're also on password reset.
Comment 2 Steven Walling 2013-12-10 23:02:10 UTC
Adding bug 55554 as a dependency, since I think we should sort that out at the same time or beforehand.
Comment 3 Matthew Flaschen 2013-12-10 23:34:23 UTC
I think this should also be blocked on bug 58297 (which I think needs to be a priority).  That way, we don't have two major changes to the most important UI on the site in close succession.

Originally, we were going to try to do this site-wide at once: https://gerrit.wikimedia.org/r/#/c/52169  I'm not sure if we should stick to that (we can probably get it done at the mw.ui hack days, though it may require a while).
Comment 4 Matthew Flaschen 2013-12-10 23:35:26 UTC
(In reply to comment #0)
> I propose that we make save an
> .mw-ui-button.mw-ui-primary button (so the blue color) while leaving Preview
> and Show changes grey but increasing the sizing to match Save.

I'm not sure exactly what you mean.  However, I think we should use the appropriate mw.ui classes for all of them, including the secondary buttons.
Comment 5 Matthew Flaschen 2014-01-02 17:03:03 UTC
Per comment 3, we should decide whether to do it all at once, or piece by piece like this.  I sent an email to https://lists.wikimedia.org/mailman/listinfo/design about this.
Comment 6 Gerrit Notification Bot 2014-03-04 07:08:30 UTC
Change 116725 had a related patch set uploaded by Deepali:
Apply mw.ui button styles to wpSave, wpPreview, and wpDiff

https://gerrit.wikimedia.org/r/116725
Comment 7 Gerrit Notification Bot 2014-03-04 19:36:18 UTC
Change 116783 had a related patch set uploaded by Deepali:
Add appropriate mw-ui button styles to Save, Preview, Show changes and cancel buttons.

https://gerrit.wikimedia.org/r/116783
Comment 8 Gerrit Notification Bot 2014-03-05 20:32:56 UTC
Change 116783 abandoned by Mattflaschen:
Add appropriate mw-ui button styles to Save, Preview, Show changes and cancel buttons.

Reason:
Abandoning duplicate change

https://gerrit.wikimedia.org/r/116783
Comment 9 Helder 2014-08-07 19:14:44 UTC
We implemented somehting like this on Portuguese Wikibooks last year. See:
https://pt.wikibooks.org/wiki/MediaWiki:Gadget-MwUi.js?uselang=en
https://pt.wikibooks.org/wiki/Project:Caixa_de_areia?action=edit&uselang=en

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links