Last modified: 2014-03-12 01:00:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60336, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58336 - Schema validation issues on mediawiki.org
Schema validation issues on mediawiki.org
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-11 18:22 UTC by Jon
Modified: 2014-03-12 01:00 UTC (History)
14 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon 2013-12-11 18:22:42 UTC
On MediaWiki.org if I open the echo notification overlay I get a flood of errors:

Validation error against schema EchoInteraction: Value "mobile-overlay" for property: context not in enum ["flyout","archive"]
Comment 1 Bingle 2013-12-11 18:35:29 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1499
Comment 2 bsitu 2013-12-21 00:45:38 UTC
This is not really an Echo problem.  In site configuration file, the Echo interaction schema is still pointing to revision: 5539940, which doesn't have 'mobile-overlay' defined.  The fix is easy, just update the schema to latest in the file and deploy the change.

Whenever something is added to the schema and the code needs to use the new definition, the schema id needs to be updated in site configuration file.
Comment 3 Jon 2013-12-21 01:56:31 UTC
I thought the revision was set in Echo extension but it sounds from what you are saying it is in a config file somewhere?

This doesn't seem like the best idea - MobileFrontend used to do that and it made updating schemas tricky. I'd really advise doing the same in Echo to avoid these types of confusion and also allow you to run 2 different revisions of schemas on 2 different codebases more easily.

Here's how we do it:
https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileFrontend.hooks.php#L706
Comment 4 Jon 2013-12-23 22:50:17 UTC
Also effecting enwiki now meaning you are not logging events there.
Comment 5 Gerrit Notification Bot 2013-12-24 23:29:13 UTC
Change 103611 had a related patch set uploaded by Kaldari:
Updating schema ID for EchoInteraction

https://gerrit.wikimedia.org/r/103611
Comment 6 Gerrit Notification Bot 2013-12-31 00:08:56 UTC
Change 103611 merged by jenkins-bot:
Updating schema ID for EchoInteraction

https://gerrit.wikimedia.org/r/103611
Comment 7 Andre Klapper 2014-03-11 17:10:33 UTC
Patch was merged a while ago - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links