Last modified: 2013-12-20 17:14:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60355, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58355 - Parsoid-related crashers in production
Parsoid-related crashers in production
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-11 22:54 UTC by ssastry
Modified: 2013-12-20 17:14 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description ssastry 2013-12-11 22:54:29 UTC
Placeholder bug for crashers. Can be split into different bugs upon further investigation

https://gist.github.com/subbuss/23b81fcc5a94242bad1a
/raw/407f472a213f8362f5fefa56ca3a656323bcc0f8/gistfile1.txt
Comment 1 Gerrit Notification Bot 2013-12-12 03:59:26 UTC
Change 100954 had a related patch set uploaded by Arlolra:
urllink can parse as an array of tokens

https://gerrit.wikimedia.org/r/100954
Comment 2 Arlo Breault 2013-12-12 07:05:41 UTC
The gist seems to have two classes of errors. One is fixed in the above patch. The other can be reproduced in a small test case like,

* test
<pre style="width:50%;" >
{{hi}}</pre>

A more degenerate case would be,

<pre style="width:50%;" >
{{hi}}</pre>

which seems to spin endlessly.

The culprit is 070efb2f96e8a4a1424f9cbf07188b049327b735, which was also responsible for https://bugzilla.wikimedia.org/show_bug.cgi?id=57650.

I'll look at fixing it tomorrow unless someone gets to it first.
Comment 3 ssastry 2013-12-12 16:35:08 UTC
More crashers: I filtered out the two crashers that are already captured in the previous gist

https://gist.github.com/subbuss/7930939/raw/5edab6d8c2a29b0b2b805202deb77a14d34e4d2c/gistfile1.txt
Comment 4 Gerrit Notification Bot 2013-12-12 20:28:13 UTC
Change 100954 merged by jenkins-bot:
urllink can parse as an array of tokens

https://gerrit.wikimedia.org/r/100954
Comment 5 Gerrit Notification Bot 2013-12-12 23:31:50 UTC
Change 101138 had a related patch set uploaded by Arlolra:
Pre can end with a space

https://gerrit.wikimedia.org/r/101138
Comment 6 Gerrit Notification Bot 2013-12-12 23:46:36 UTC
Change 101138 merged by jenkins-bot:
Pre can end with a space

https://gerrit.wikimedia.org/r/101138
Comment 7 Gerrit Notification Bot 2013-12-13 01:09:54 UTC
Change 101162 had a related patch set uploaded by GWicke:
Bug 58355: Accept html pre with attribute and trailing space

https://gerrit.wikimedia.org/r/101162
Comment 8 Gerrit Notification Bot 2013-12-13 05:18:51 UTC
Change 101162 merged by jenkins-bot:
Bug 58355: Accept html pre with attribute and trailing space

https://gerrit.wikimedia.org/r/101162
Comment 9 Gerrit Notification Bot 2013-12-13 19:56:08 UTC
Change 101353 had a related patch set uploaded by GWicke:
urllink can parse as an array of tokens

https://gerrit.wikimedia.org/r/101353
Comment 10 Gerrit Notification Bot 2013-12-13 19:56:12 UTC
Change 101355 had a related patch set uploaded by GWicke:
Pre can end with a space

https://gerrit.wikimedia.org/r/101355
Comment 11 Gerrit Notification Bot 2013-12-13 19:56:15 UTC
Change 101356 had a related patch set uploaded by GWicke:
Bug 58355: Accept html pre with attribute and trailing space

https://gerrit.wikimedia.org/r/101356
Comment 12 Gerrit Notification Bot 2013-12-13 19:56:25 UTC
Change 101356 merged by GWicke:
Bug 58355: Accept html pre with attribute and trailing space

https://gerrit.wikimedia.org/r/101356
Comment 13 Gerrit Notification Bot 2013-12-13 19:56:27 UTC
Change 101355 merged by GWicke:
Pre can end with a space

https://gerrit.wikimedia.org/r/101355
Comment 14 Gerrit Notification Bot 2013-12-13 19:56:30 UTC
Change 101353 merged by GWicke:
urllink can parse as an array of tokens

https://gerrit.wikimedia.org/r/101353
Comment 15 Arlo Breault 2013-12-13 21:26:39 UTC
There's still the second gist to do here. Looking at it now.
Comment 16 Gerrit Notification Bot 2013-12-16 22:03:10 UTC
Change 102007 had a related patch set uploaded by Arlolra:
Ensure data.query is present in template request

https://gerrit.wikimedia.org/r/102007
Comment 17 Gerrit Notification Bot 2013-12-17 07:41:15 UTC
Change 102084 had a related patch set uploaded by Arlolra:
Handle fostered foster boxes

https://gerrit.wikimedia.org/r/102084
Comment 18 Gerrit Notification Bot 2013-12-18 16:54:29 UTC
Change 102007 merged by GWicke:
Ensure data.query is present in template request

https://gerrit.wikimedia.org/r/102007
Comment 19 Gerrit Notification Bot 2013-12-20 17:06:37 UTC
Change 102084 merged by jenkins-bot:
Handle fostered foster boxes

https://gerrit.wikimedia.org/r/102084
Comment 20 ssastry 2013-12-20 17:14:27 UTC
That last patch addresses the last of the crashers reported in the production logs.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links