Last modified: 2013-12-11 23:55:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60358, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58358 - URLs in user CSS are damaged by load.php
URLs in user CSS are damaged by load.php
Status: RESOLVED DUPLICATE of bug 58338
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
unspecified
All All
: Unprioritized major (vote)
: ---
Assigned To: Nobody - You can work on this!
http://bits.wikimedia.org/www.mediawi...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-11 23:43 UTC by PartTimeGnome
Modified: 2013-12-11 23:55 UTC (History)
5 users (show)

See Also:
Web browser: Opera
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description PartTimeGnome 2013-12-11 23:43:31 UTC
MediaWiki 1.23wmf6, on MediaWiki.org

See my user CSS at http://www.mediawiki.org/w/index.php?title=User:PartTimeGnome/common.css&oldid=840694. Note the three URLs I am @importing.

Now look at the output from load.php: http://bits.wikimedia.org/www.mediawiki.org/load.php?debug=true&modules=user&only=styles&user=PartTimeGnome&version=20131211T224542Z&*

The first URL is fine. The remaining two have their double quotes stripped, and everything after the '?' in each URL is removed.

I don't get this problem on the English Wikipedia (on 1.23wmf5). My CSS is slightly different there (it only has two URLs, not three). (Example of the correct load.php output on enWP: http://bits.wikimedia.org/en.wikipedia.org/load.php?debug=true&modules=user&only=styles&user=PartTimeGnome&version=20131018T225414Z&*
Comment 1 Kunal Mehta (Legoktm) 2013-12-11 23:44:55 UTC
Bug has been fixed and is pending deployment.

*** This bug has been marked as a duplicate of bug 58338 ***
Comment 2 Bartosz Dziewoński 2013-12-11 23:55:05 UTC
(On a side note, the quotes are entirely optional unless your URL contains unescaped parentheses, spaces, quotes themselves or other funny characters.
They will still be stripped here after the fix from bug 58338 is deployed.)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links