Last modified: 2014-02-09 23:14:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60372, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58372 - Flow: Can't reply to a thread after clicking the Comment(4) link in header.
Flow: Can't reply to a thread after clicking the Comment(4) link in header.
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
https://www.mediawiki.org/wiki/Talk:S...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-12 04:26 UTC by MarkJurgens
Modified: 2014-02-09 23:14 UTC (History)
9 users (show)

See Also:
Web browser: Google Chrome
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MarkJurgens 2013-12-12 04:26:15 UTC
Intention:
I was trying to make the topics expand and collapse by clicking the comments button  Comments(3)  Comments(4) etc.. depending on thread.

Steps to Reproduce:
1. Scroll to the bottom of any thread. Click in the textbox and note that reply becomes visible as you start typing.
2. Scroll up the top of that thread. Click the link that says something like " Comments(3)"
3. Scroll down to the textbox. Start typing. The reply button doesn't highlight as an option.

Actual Results:  
I'm unable to hit the 'reply' button after typing, to add my reply to the discussion.

Expected Results:  
To be able to hit reply!

Reproducible: Always

https://www.dropbox.com/s/qzxy18ztdeqvd7f/NoReply.png
Comment 1 Bingle 2013-12-12 04:30:22 UTC
The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/614, but people from the community are welcome to contribute here and in Gerrit.
Comment 2 Oliver Keyes 2013-12-12 19:23:36 UTC
Oh no :/. Browser/OS?
Comment 3 Andrew Garrett 2013-12-17 02:39:28 UTC
I'm quite confused by this bug.

It's happening directly because of the "don't let users submit until the textbox has something in it" feature. For some reason it thinks that the textbox is always empty.

When you set a breakpoint on the appropriate spot in ext.flow.editor.none.js, you find that this.$node is a whole bunch of different textareas.

Further investigation indicates that the node that an editor is responsible for is stored inside the editor itself, which is fine until you realise that that editor is reused for all of the nodes. So how does the editor know which of the nodes to check for text in?

Yet, when you open a number of different editors across the page, they all seem to work correctly. So clearly it's working *somehow*.

Adding Matthias to CC, since he wrote most of the editor code.
Comment 4 Andrew Garrett 2013-12-17 09:25:56 UTC
Yeah, my impression here was wrong. Looking at it now.
Comment 5 Gerrit Notification Bot 2014-01-03 00:57:41 UTC
Change 105123 had a related patch set uploaded by Bsitu:
Fix issues on clicking "x comments" link

https://gerrit.wikimedia.org/r/105123
Comment 6 Gerrit Notification Bot 2014-01-16 22:35:43 UTC
Change 105123 merged by jenkins-bot:
Fix issues on clicking "x comments" link

https://gerrit.wikimedia.org/r/105123

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links