Last modified: 2014-09-04 13:36:26 UTC
With the rest of MW, attempts to leave, say, the edit window after you've already modified stuff (but not hit save) prompt a warning message that informs people their data won't be saved, etc, etc. Flow lacks this. It shouldn't ;p.
The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/616, but people from the community are welcome to contribute here and in Gerrit.
The warning is preference-based, and comes from: [[Special:Preferences#mw-prefsection-editing]] "Warn me when I leave an edit page with unsaved changes" name="wpuseeditwarning" id="mw-input-wpuseeditwarning"
Shouldn't that option be removed from Preferences? Shall I remove it?
I would like to work on this bug.
Then you're welcome to; bear in mind that Flow is under active development, so others may be writing/have written patches.
(In reply to comment #3) > Shouldn't that option be removed from Preferences? Shall I remove it? Not as part of this bug, no. (and in general, no, but that decision isn't up to me -- open a new bug or search for an existing one if you really think it shouldn't be there to start a discussion on it). If you fix this bug, it should ideally honor that preference setting, so when that pref is disabled leaving a page with unsaved comments in Flow should not prompt the user, but when it is enabled the prompts happen.
Agreed with Ryan. A bugzilla thread is not the place for making those kind of changes; the task should be supporting the pref, not removing it for everyone.
(In reply to comment #7) > Agreed with Ryan. A bugzilla thread is not the place for making those kind of > changes; the task should be supporting the pref, not removing it for > everyone. Got it.Thanks.
(In reply to comment #5) > Then you're welcome to; bear in mind that Flow is under active development, > so > others may be writing/have written patches. Oh! How do I get a clue if someone has already written a patch?
The bug should have the status PATCH_TO_REVIEW, or be actively assigned to someone.
This is partially fixed, via https://gerrit.wikimedia.org/r/#/c/148983/ I tested at mediawiki, and it now warns the user when they try to navigate away, if text has been entered anywhere. (yay!) However, if I turn off the "useeditwarning" preference, ("Warn me when I leave an edit page with unsaved changes" in [[mw:Special:Preferences#mw-prefsection-editing]]) then it still warns me when trying to navigate away. So, I'll leave the bug open, but reduce the importance.
Original bug about warning is dealt with. I split the other part of this bug into a new bug report to make it easier to follow to a volunteer: https://bugzilla.wikimedia.org/show_bug.cgi?id=70399
