Last modified: 2013-12-13 20:19:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60404, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 58404 - VisualEditor: The toolbar design inside the MediaSettings and Reference does not match with the new toolbar design on main CE


Summary:	VisualEditor: The toolbar design inside the MediaSettings and Reference does ...

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Editing Tools (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High minor
Target Milestone:	VE-deploy-2013-12-12
Assigned To:	James Forrester

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-12-12 18:49 UTC by Rummana Yasmeen
Modified:	2013-12-13 20:19 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Screenshot inside reference (47.94 KB, image/png) 2013-12-12 18:49 UTC, Rummana Yasmeen	Details
toolbar inside media settings (57.80 KB, image/png) 2013-12-12 18:51 UTC, Rummana Yasmeen	Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2013-12-12 18:49:21 UTC

Created attachment 14072 [details]
Screenshot inside reference

We have changed the toolbar design to have all the formatting under one button A (underlined) and all other options to add elements under Insert option.

But if you open up the Media Settings or a Reference the toolbar that appears there does not conform with the new design.
It will better to have a consistent design everywhere the toolbar is used.

See the screemshots attached.

Comment 1 Rummana Yasmeen 2013-12-12 18:51:19 UTC

Created attachment 14073 [details]
toolbar inside media settings

Comment 2 Gerrit Notification Bot 2013-12-12 19:22:51 UTC

Change 101039 had a related patch set uploaded by Jforrester:
Use the same new toolbar for media and reference dialogs

https://gerrit.wikimedia.org/r/101039

Comment 3 Gerrit Notification Bot 2013-12-12 19:31:47 UTC

Change 101047 had a related patch set uploaded by Jforrester:
Use the same new toolbar for media and reference dialogs

https://gerrit.wikimedia.org/r/101047

Comment 4 Gerrit Notification Bot 2013-12-12 19:32:24 UTC

Change 101039 merged by jenkins-bot:
Use the same new toolbar for media and reference dialogs

https://gerrit.wikimedia.org/r/101039

Comment 5 Gerrit Notification Bot 2013-12-12 23:16:18 UTC

Change 101047 merged by Catrope:
Use the same new toolbar for media and reference dialogs

https://gerrit.wikimedia.org/r/101047

Comment 6 James Forrester 2013-12-12 23:20:27 UTC

Now being deployed on wmf7.

Comment 7 Rummana Yasmeen 2013-12-13 20:19:51 UTC

verified the fix in test2:https://test2.wikipedia.org/w/index.php?title=User:RYasmeen_(WMF)&veaction=edit

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links