Last modified: 2014-03-31 11:43:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60414, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 58414 - SpecialTranslatorSignup::getOtherWikis() returns closed, private and fishbowl wikis


Summary:	SpecialTranslatorSignup::getOtherWikis() returns closed, private and fishbowl...

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	TranslationNotifications (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-12-12 22:22 UTC by Bryan Davis
Modified:	2014-03-31 11:43 UTC (History)
CC List:	7 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bryan Davis 2013-12-12 22:22:33 UTC

getOtherWikis() seems to be intended to return all.dblist minus the closed, private and fishbowl dblist files. In the current implementation however it seems to always return the entire all.dblist due at least in part to some small programming errors.

* $wgDBname is used inside the loop instead of $dbname
* SiteMatrix::isPrivate() and SiteMatrix::isFishbowl() expect to be called with a database name rather than a site & language pair

Comment 1 Gerrit Notification Bot 2013-12-12 22:28:02 UTC

Change 101128 had a related patch set uploaded by BryanDavis:
Fix SpecialTranslatorSignup::getOtherWikis()

https://gerrit.wikimedia.org/r/101128

Comment 2 Gerrit Notification Bot 2014-01-07 16:27:53 UTC

Change 101128 merged by jenkins-bot:
Fix SpecialTranslatorSignup::getOtherWikis()

https://gerrit.wikimedia.org/r/101128

Comment 3 Amir E. Aharoni 2014-03-31 11:43:45 UTC

Thanks for the fix.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links