Last modified: 2013-12-30 10:09:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60421, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 58421 - VisualEditor: removeHtmlAttributes throws an exception when copying complex templates


Summary:	VisualEditor: removeHtmlAttributes throws an exception when copying complex t...

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Editing Tools (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal
Target Milestone:	VE-deploy-2013-12-19
Assigned To:	Ed Sanders

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-12-12 23:29 UTC by Rummana Yasmeen
Modified:	2013-12-30 10:09 UTC (History)
CC List:	6 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
screenshot (187.03 KB, image/png) 2013-12-12 23:32 UTC, Rummana Yasmeen	Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2013-12-12 23:29:54 UTC

Steps to reproduce:

1.Open the editor.
2.Add a template
3.Save the page
4.Reopen the editor
5.Copy the template 

Observed Result:

It gives an error:Uncaught TypeError: Cannot convert null to object .However, it does get pasted correctly onto other VE.

Comment 1 Rummana Yasmeen 2013-12-12 23:31:43 UTC

Test Environment: production-https://en.wikipedia.org/
Browser: Chrome Version 26.0.1410.65 &       FF 25
OS: MAC OS X 10. 8. 5

Comment 2 Rummana Yasmeen 2013-12-12 23:32:41 UTC

Created attachment 14077 [details]
screenshot

Comment 3 Ed Sanders 2013-12-13 00:03:19 UTC

Can you reproduce on beta labs?

Comment 4 Gerrit Notification Bot 2013-12-13 00:07:30 UTC

Change 101148 had a related patch set uploaded by Esanders:
Check values property exists before remove attribute

https://gerrit.wikimedia.org/r/101148

Comment 5 Rummana Yasmeen 2013-12-13 01:03:55 UTC

For betalabs, I could reproduce for only templates which has parameters with values

Comment 6 Gerrit Notification Bot 2013-12-13 19:39:44 UTC

Change 101148 merged by jenkins-bot:
Check values property exists before removing attribute

https://gerrit.wikimedia.org/r/101148

Comment 7 Rummana Yasmeen 2013-12-14 03:54:21 UTC

Verified the fix in betalabs:http://en.wikipedia.beta.wmflabs.org/wiki/The_destination_template

Comment 8 Rummana Yasmeen 2013-12-19 20:26:34 UTC

Verified the fix in test2 with MediaWiki 1.23wmf8 on page:
https://test2.wikipedia.org/wiki/19th_december

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links