Last modified: 2014-01-12 08:40:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60434, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58434 - Oracle installer uses invalid function invocation and fails
Oracle installer uses invalid function invocation and fails
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
1.22.0
All All
: High major (vote)
: 1.22.x release
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: oracle
  Show dependency treegraph
 
Reported: 2013-12-13 03:38 UTC by John Mark Vandenberg
Modified: 2014-01-12 08:40 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---
hashar: Backport_to_Stable+


Attachments

Description John Mark Vandenberg 2013-12-13 03:38:03 UTC
Stepping through the installer, using Oracle, always returns the error 'config-invalid-db-server-oracle', which is

Invalid database TNS "$1".
Use either "TNS Name" or an "Easy Connect" string ([http://docs.oracle.com/cd/E11882_01/network.112/e10836/naming.htm Oracle Naming Methods])

OracleInstaller::submitConnectForm calls WebInstaller::setVarsFromRequest with each desired form field name as a separate parameter instead of an array in the first parameter as specified in the API documentation.

The bug was introduced in this patch, late in October 2013

https://gerrit.wikimedia.org/r/#/c/88466/

-		$newValues = $this->setVarsFromRequest( array( 'wgDBserver', 'wgDBprefix', 'wgDBuser', 'wgDBpassword' ) );
+		$newValues = $this->setVarsFromRequest( 
+			'wgDBserver',
+			'wgDBprefix',
+			'wgDBuser',
+			'wgDBpassword'
+		);
Comment 1 Nemo 2013-12-30 09:29:33 UTC
Update per https://www.mediawiki.org/w/index.php?title=MediaWiki_1.22/Known_issues&oldid=847749 which seems to be the master list.
Comment 2 Gerrit Notification Bot 2014-01-07 18:56:49 UTC
Change 105980 had a related patch set uploaded by Umherirrender:
DatabaseInstaller::setVarsFromRequest needs array

https://gerrit.wikimedia.org/r/105980
Comment 3 Umherirrender 2014-01-07 18:58:34 UTC
Just for reference: I have no oracle to test this patch, I have only fix the point mentioned in comment 0 and I hope that helps.
Comment 4 Gerrit Notification Bot 2014-01-07 19:13:48 UTC
Change 105985 had a related patch set uploaded by Siebrand:
DatabaseInstaller::setVarsFromRequest needs array

https://gerrit.wikimedia.org/r/105985
Comment 5 Nemo 2014-01-07 19:19:39 UTC
No + till merge, according to policy
Comment 6 Gerrit Notification Bot 2014-01-07 19:29:01 UTC
Change 105980 merged by jenkins-bot:
DatabaseInstaller::setVarsFromRequest needs array

https://gerrit.wikimedia.org/r/105980
Comment 7 Gerrit Notification Bot 2014-01-12 02:58:36 UTC
Change 105985 merged by jenkins-bot:
DatabaseInstaller::setVarsFromRequest needs array

https://gerrit.wikimedia.org/r/105985
Comment 8 Umherirrender 2014-01-12 08:40:55 UTC
master and release fixed now fixed

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links