Last modified: 2013-12-13 20:03:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60436, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 58436 - Call to a member function isError() on a non-object in includes/filerepo/file/File.php on line 907
Call to a member function isError() on a non-object in includes/filerepo/file...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-12-13 07:46 UTC by Siebrand Mazeland
Modified: 2013-12-13 20:03 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Siebrand Mazeland 2013-12-13 07:46:20 UTC 
Observed at translatewiki.net: PHP Fatal error:  Call to a member function isError() on a non-object in /www/translatewiki.net/w/includes/filerepo/file/File.php on line 907

Code snippet:

        $thumb = $this->transform( $params );
        if ( is_null( $thumb ) || $thumb->isError() ) {
            return '';
        }

Happens when $thumb is false, which means that $thumb->isError() is called on a non-object.
Comment 1 Gerrit Notification Bot 2013-12-13 08:02:26 UTC 
Change 101179 had a related patch set uploaded by Brian Wolff:
Fix error handling in File::createThumb.

https://gerrit.wikimedia.org/r/101179
Comment 2 Gerrit Notification Bot 2013-12-13 18:17:32 UTC 
Change 101179 merged by jenkins-bot:
Fix error handling in File::createThumb.

https://gerrit.wikimedia.org/r/101179
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links