Last modified: 2013-12-14 06:33:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60448, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58448 - Drop "Content-disposition: attachment;" from the response headers if the MIME type can be typically rendered by the browser
Drop "Content-disposition: attachment;" from the response headers if the MIME...
Status: RESOLVED DUPLICATE of bug 54181
Product: Wikimedia
Classification: Unclassified
Bugzilla (Other open bugs)
wmf-deployment
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-13 14:13 UTC by Rainer Rillke @commons.wikimedia
Modified: 2013-12-14 06:33 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rainer Rillke @commons.wikimedia 2013-12-13 14:13:52 UTC
Original Bug title:
Drop "Content-disposition: attachment;" from the response headers if the MIME type can be typically rendered by the browser, including text, png and jpg files.
----

Reasoning:
This header forces the browser to open a download-dialog which is not really handy for quickly looking at a screenshot. Downloading is still possible for all who are fans of error-screenshots after removing that header.

----

Possible issue: Bugzilla is abused by spammers for placing their images here.
Possible solution: Only drop the header if user is logged-in.

Possible issue: Injection of malicious content.
Possible solution: Only allow "safe types" (i.e. not .js or only png and jpg images)

----
----
Current response headers for attachments:

HTTP/1.1 200 OK
Date: Fri, 13 Dec 2013 13:56:58 GMT
Server: Apache
X-xss-protection: 1; mode=block
Content-disposition: attachment; filename="commons_revision_missing_not_in_user_language.png"
X-content-type-options: nosniff
Content-length: 287653
Keep-Alive: timeout=15, max=100
Connection: Keep-Alive
Content-Type: image/png; name="commons_revision ..."
Comment 1 Bartosz Dziewoński 2013-12-13 14:16:10 UTC
Yeah, it's really about time someone fixed this.

*** This bug has been marked as a duplicate of bug 54181 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links