Last modified: 2013-12-13 21:21:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60455, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 58455 - Flow: & in wikilink triggers exception, Flow doesn't render
Flow: & in wikilink triggers exception, Flow doesn't render
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Highest blocker (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-12-13 18:43 UTC by spage
Modified: 2013-12-13 21:21 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description spage 2013-12-13 18:43:55 UTC 
[[Bad&Link]] in wikitext causes exception and Flow fails rendering.

To reproduce, put "4[[Bad&Link]] here" in a reply and click [Preview]

"internal_api_error_MWException"
	
info
	"Exception Caught: "
	
*
	" #0 /srv/mediawiki/extensions/Flow/includes/Templating.php(435): Flow\ParsoidUtils::createDOM('<a href="/w/ind...') #1 /srv/mediawiki/extensions/Flow/includes/Templating.php(362): Flow\Templating->applyRedlinks('<p data-parsoid...') #2 /srv/mediawiki/extensions/Flow/templates/post.html.php(87): Flow\Templating->getContent(Object(Flow\Model\PostRevision), 'html', Object(User)) #3 /srv/mediawiki/extensions/Flow/includes/Templating.php(96): include('/srv/mediawiki/...') #4 /srv/mediawiki/extensions/Flow/includes/Templating.php(70): Flow\Templating->_render('/srv/mediawiki/...', Array) #5 /srv/mediawiki/extensions/Flow/includes/Templating.php(139): Flow\Templating->render('flow:post.html....', Array, true) #6 /srv/mediawiki/extensions/Flow/includes/Block/Topic.php(323): Flow\Templating->renderPost(Object(Flow\Model\PostRevision), Object(Flow\Block\TopicBlock)) #7 /srv/mediawiki/extensions/Flow/includes/api/ApiFlow.php(109): Flow\Block\{closure}(Object(Flow\Templating)) #8 /srv/mediawiki/extensions/Flow/includes/api/ApiFlow.php(70): ApiFlow->processCommitResult(Array, true) #9 /srv/mediawiki/includes/api/ApiMain.php(829): ApiFlow->execute() #10 /srv/mediawiki/includes/api/ApiMain.php(380): ApiMain->executeAction() #11 /srv/mediawiki/includes/api/ApiMain.php(351): ApiMain->executeActionWithErrorHandling() #12 /srv/mediawiki/api.php(73): ApiMain->execute()
Comment 1 Gerrit Notification Bot 2013-12-13 18:46:08 UTC 
Change 101236 had a related patch set uploaded by Spage:
Gracefully handle errors applying redlinks

https://gerrit.wikimedia.org/r/101236
Comment 2 Gerrit Notification Bot 2013-12-13 19:02:03 UTC 
Change 101236 merged by jenkins-bot:
Gracefully handle errors applying redlinks

https://gerrit.wikimedia.org/r/101236
Comment 3 Gerrit Notification Bot 2013-12-13 19:15:29 UTC 
Change 101249 had a related patch set uploaded by Spage:
Gracefully handle errors applying redlinks (wmf7)

https://gerrit.wikimedia.org/r/101249
Comment 4 Gerrit Notification Bot 2013-12-13 19:20:26 UTC 
Change 101249 merged by jenkins-bot:
Gracefully handle errors applying redlinks (wmf7)

https://gerrit.wikimedia.org/r/101249
Comment 5 Gerrit Notification Bot 2013-12-13 19:28:46 UTC 
Change 101253 had a related patch set uploaded by Spage:
Update Flow with backported bug 58455 backport

https://gerrit.wikimedia.org/r/101253
Comment 6 Gerrit Notification Bot 2013-12-13 19:43:46 UTC 
Change 101253 merged by jenkins-bot:
Update Flow with backported bug 58455 backport

https://gerrit.wikimedia.org/r/101253
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links