Last modified: 2014-04-29 10:02:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60473, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58473 - CSSMin's url() value processing doesn't allow parentheses or quotes in the URL
CSSMin's url() value processing doesn't allow parentheses or quotes in the URL
Status: NEW
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-13 22:47 UTC by James Forrester
Modified: 2014-04-29 10:02 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Forrester 2013-12-13 22:47:03 UTC
I have a cross-wiki @import in my personal common.js and common.css pages (on all WMF public wikis) – e.g. https://www.mediawiki.org/w/index.php?title=User:Jdforrester_(WMF)/common.css&oldid=605983 – of the form:

@import url('//meta.wikimedia.org/w/index.php?title=User:Jdforrester (WMF)/global.css&action=raw&ctype=text/css');

Until recent changes unveiled this bug, this worked fine, but now the first parenthesis aborts the import (so it runs as "@import url('//meta.wikimedia.org/w/index.php?title=User:Jdforrester (WMF"), which unsurprisingly 404s.

I can fix this for myself with a bot edit to 1600 pages (fun) to URL-encode the parentheses, but this regression should actually be fixed.
Comment 1 Bartosz Dziewoński 2013-12-13 22:57:05 UTC
Not a regression, it never did, but previous that was not applied to @imports and thus no one ever noticed.

This is rather low-priority, given that normal people don't have parentheses in their names and don't have @import rules in their personal CSS.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links