Last modified: 2014-02-12 23:55:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60540, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 58540 - Unsightly blue highlight when toggling open sections


Summary:	Unsightly blue highlight when toggling open sections

Status:	RESOLVED DUPLICATE of bug 58978

Product:	MobileFrontend
Classification:	Unclassified
Component:	stable (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-12-16 18:37 UTC by Jon
Modified:	2014-02-12 23:55 UTC (History)
CC List:	11 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Blue highlight (37.60 KB, image/png) 2013-12-16 18:37 UTC, Jon	Details
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2013-12-16 18:37:44 UTC

Created attachment 14108 [details]
Blue highlight

Recent accessibility changes to code mean that sections now get highlighted when toggled open. I'm not sure whether we want this or not as it looks very strange (see attachment)

Comment 1 Bingle 2013-12-16 18:55:29 UTC

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1513

Comment 2 Marius Hoch 2013-12-16 22:16:35 UTC

I don't really care what you do with this on mobile (probably doesn't matter much over there). But please don't disable the outline on desktop platforms, as it's the only way to see what currently has focus (important if using keyboard navigation).

Comment 3 Gerrit Notification Bot 2013-12-26 14:43:53 UTC

Change 103750 had a related patch set uploaded by JGonera:
Remove focus outlines on touch devices

https://gerrit.wikimedia.org/r/103750

Comment 4 Jon 2013-12-26 18:22:44 UTC

This patch didn't fix the bug - need to use the following for that:

	-webkit-tap-highlight-color: rgba(255, 255, 255, 0); 
	tap-highlight-color: rgba(255, 255, 255, 0);

Comment 5 Juliusz Gonera 2013-12-26 18:32:01 UTC

Either the bug has a wrong screenshot attached to it, or the patch did fix the bug. tap-highlight-color changes the background when something is tapped, not the outline shown in the screenshot.

Comment 6 Jon 2013-12-26 20:45:30 UTC

I've created a new bug to make you happier.

*** This bug has been marked as a duplicate of bug 58978 ***

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links