Last modified: 2013-12-19 02:00:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60551, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58551 - VisualEditor: Broken on mobile due to ULS dependency
VisualEditor: Broken on mobile due to ULS dependency
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Mobile (Other open bugs)
unspecified
All All
: Highest normal
: VE-deploy-2013-12-19
Assigned To: Rob Moen
: mobile
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-16 21:35 UTC by Jon
Modified: 2013-12-19 02:00 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon 2013-12-16 21:35:56 UTC
When loaded in alpha on beta labs I get 
Error: Unknown dependency: jquery.uls Error {} 

Given this is the second dependency related error I've now seen I'm a bit concerned about the speed at which dependencies are added to the mobile version of VisualEditor. Is there a way to better sandbox the mobile code? I find it hard to believe that ULS is actually needed for the stripped down mobile version.
Comment 1 Gerrit Notification Bot 2013-12-18 01:32:17 UTC
Change 102368 had a related patch set uploaded by Jdlrobson:
Move additional module loading to viewPage vs general target

https://gerrit.wikimedia.org/r/102368
Comment 2 Gerrit Notification Bot 2013-12-18 15:36:21 UTC
Change 102368 merged by jenkins-bot:
Move additional module loading from mw.Target to mw.ViewPageTarget

https://gerrit.wikimedia.org/r/102368

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links